Minor metadata fixes #788
Merged
Minor metadata fixes #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- unsupported basis_of_value
code used:
subs <- read_metadata("data/ANBG_2019/metadata.yml")
-- then manually removed all substitutions --
subs$substitutions %>% util_list_to_df2() %>% distinct(find, .keep_all = TRUE) -> to_read_in
metadata_add_substitutions_list("ANBG_2019", to_read_in)
…/austraits.build into minor-metadata-fixes
…/austraits.build into minor-metadata-fixes
…/austraits.build into minor-metadata-fixes
…/austraits.build into minor-metadata-fixes
remove comma
…/austraits.build into minor-metadata-fixes
- remove unneeded taxonomic updates - add missing rows to Nano
…/austraits.build into minor-metadata-fixes
- removing duplicate upodates - removing updates for taxa not in data.csv files - I am somewhat baffled how these got added; almost all are automatic adds; I think they represent secondary changes to a primary name change, where the primary name change eventually got changed itself, so there is no link... there are 100's more of these and eventually I'll programatically remove them, but still wanting to check they really are all vestiges.
Yeah! Removed/changed lots of taxonomic updates that yielded errors and the only change adds an actual name!
removing taxonomic updates that don't match a taxon name in the data file - strange artifacts from long ago. Removing large numbers of these has no effect on taxon list rebuilding
…/austraits.build into minor-metadata-fixes
...but now austraits$traits suddenly has 6214 fewer entries, compared with a few commits ago... will compare
…/austraits.build into minor-metadata-fixes
- Lots of excluded data from mistyped substitutions - Also taxonomic_updates
- many of these unneeded names exist because the same list of taxon updates was used for all WAH studies (& then Wenk_2022), even though some taxa didn't have data scored in some datasets - this was the first set of "unneeded" taxon removals that deleted ~10-15 taxon names from taxon_list because of the deleted substitutions - these were taxon names for which there is data. Temporarily reinstating.
- all tests active again, all passing
1 final change
dfalster
approved these changes
Nov 19, 2023
dfalster
reviewed
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endless small changes to match new tests