Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build_update_taxon_list.R #789

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

yangsophieee
Copy link
Collaborator

  • Add dplyr:: prefix to filter functions to avoid conflicts with stats::filter
  • Clean formatting

This is before I import it to traits.build

- Add `dplyr::` prefix to `filter` functions
- Clean formatting
@yangsophieee yangsophieee requested a review from ehwenk November 22, 2023 23:26
R/build_update_taxon_list.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@ehwenk ehwenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - but curious how many of the reformatting were automated by R vs intentional? (To avoid this happening in reverse when I next edit it with different RStudio settings, since it makes it hard to see the actual changes.)

@yangsophieee
Copy link
Collaborator Author

@ehwenk The removal of trailing whitespaces is an automated shortcut I have on VS Code any time I save a file (it's not to do with R settings). Everything else was intentional reformatting.

@yangsophieee yangsophieee merged commit 51964db into develop Nov 23, 2023
1 check passed
@yangsophieee yangsophieee deleted the clean_build_update_taxon_list branch November 23, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants