-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate flora data & add authorship to flora data #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filter SAH_2014 to only retain trait values that aren't also in SAH_2022, SAH_2023. As part of this, SAH_2014 is now in long-format.
...the problem is that the way to filter NTH_2014 vs new scrapings is by comparing austraits output, which means that other than `original_name` none of the information from the original dataset is retained (i.e. "un-doing" substitutions)
- have removed all leaf width, leaf lengths, plant heights EXCEPT if the taxa are completely missing from ABRS_2022, 2023. There are about 1000 values to manually check - well over 50% were wrong plant part or wrong number, so they are simply saved in the raw data folder
easy, because virtually no numeric traits, almost all trait values that were only in WAH_1998 were flowering times
still need to redo metadata files
- merge in authorship info for individual profiles, under `measurement_remarks`
multiple bugs fixed now only 1.56 million rows of data.... there were lots of duplicates
Nice work @ehwenk. This is quite a big PRE so we'll need to look at together sometime |
dfalster
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have reviewed this together with @ehwenk . Huge amount of work. Hard to catch any issues without reviewing original sources, I am approving without going that far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two pieces of work on this branch that cause most data.csv files for datasets with flora data to be completely overwritten:
Overall, this has removed ~100,000 data points. These are almost entirely true duplicates: