Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows fix #11

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Windows fix #11

merged 2 commits into from
Apr 9, 2024

Conversation

Tess-LaCoil
Copy link
Collaborator

Implemented change to configure.win that corrected compile problem in Win10 desktop per this comment:
https://discourse.mc-stan.org/t/pkgbuild-compile-dll-on-previously-working-rstantools-based-package-fails-with-file-too-big-error/21938/16
Did not implement change to configure file as this had caused problems previously.

All tests passed: https://github.com/traitecoevo/rmot/actions/runs/8596357738
Removed windows-fix from the CI test workflow after successful.

@Tess-LaCoil Tess-LaCoil requested a review from fontikar April 8, 2024 08:12
Copy link
Collaborator

@fontikar fontikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Tess-LaCoil Tess-LaCoil merged commit 3c53935 into master Apr 9, 2024
6 checks passed
@Tess-LaCoil Tess-LaCoil deleted the windows-fix branch April 9, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants