Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canham model add #12

Merged
merged 6 commits into from
Apr 9, 2024
Merged

Canham model add #12

merged 6 commits into from
Apr 9, 2024

Conversation

Tess-LaCoil
Copy link
Collaborator

Added the Canham model material. I had to slightly change the testing code in order to include RK4 stan models that require a step size as argument.

All tests passed: https://github.com/traitecoevo/rmot/actions/runs/8610555357
have subsequently removed the branch from the testing workflow.

@Tess-LaCoil Tess-LaCoil requested review from dfalster and fontikar April 9, 2024 05:23
Copy link
Member

@dfalster dfalster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising, some minor suggested changes.

I can't see any issues with stan files, but it's also end of the day!

tests/testthat/helper-testing.R Outdated Show resolved Hide resolved
tests/testthat/helper-testing.R Show resolved Hide resolved
tests/testthat/helper-testing.R Show resolved Hide resolved
tests/testthat/test-rmot_models_canham.R Outdated Show resolved Hide resolved
…model, including constant. Changed helper function to better iterate over parameter names.
@Tess-LaCoil Tess-LaCoil merged commit ce622f1 into master Apr 9, 2024
8 checks passed
@Tess-LaCoil Tess-LaCoil deleted the canham-model-add branch April 9, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants