-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Power model add #13
Power model add #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Nice work so glad we have a workflow now! :D Have no viewed Stan files in much detail, @dfalster can we lean on you for that please? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Tess. Looks great. However, I suggest we write power law as dx/dt = a (x/x_c)^b. Your implementation has x_c=1. a general guide would be that x_c ~= mean(x), but rather than estimating from the data, it would be better to set this in the model setup as a specified quantify. Without this, the slope and intercept become heavily correlated and hard to converge.
… references in helper functions for testing and data generation.
Changes to power law model done. @dfalster I don't know if the data generation process is sane as I produce y_bar values and pass them along with the other DE parameters to used to determine true sizes over time. Those true values also get passed to the model, but I assume in practice these would be estimated from the data or something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry , more changes!
…_bar, including the data generation process. Currently fails to properly estimate coefficient parameter for single individual.
…er functions to use map rather than for loop.
Added the power law model.