Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vb model add #25

Merged
merged 9 commits into from
Jul 27, 2024
Merged

Vb model add #25

merged 9 commits into from
Jul 27, 2024

Conversation

Tess-LaCoil
Copy link
Collaborator

Finally worked out why the vB model wasn't working, the large step size allowed pathological parameters due to the numerical method. This warrants further investigation but not within this package.

  • Fixed vB testing Issue #21
  • Updated power law to de-centralise Issue #24
  • Changed testing infrastructure to be more general and allow vB/power law models that have additional y_bar parameter in the data.

@Tess-LaCoil Tess-LaCoil requested a review from dfalster July 26, 2024 09:20
Copy link
Member

@dfalster dfalster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work!

See one point of clarification

tests/testthat/fixtures/power/make_power.R Show resolved Hide resolved
@Tess-LaCoil Tess-LaCoil merged commit 8d7d23a into master Jul 27, 2024
4 checks passed
@Tess-LaCoil Tess-LaCoil deleted the vb-model-add branch July 27, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants