Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant single individual #6

Closed
wants to merge 33 commits into from
Closed

Conversation

Tess-LaCoil
Copy link
Collaborator

Added stan file, data template, and data template testing for the constant model with a single individual. Also tidied up some of the code and comments so that the single and multiple individuals for the constant model would be more clearly matched.

Tess-LaCoil and others added 4 commits October 17, 2023 14:52
* Updated notation and function structure in the multi individual constant model file for consistency. Updated rmot_run, rmot_models to reflect the changes.

* Removed old constant stan file and cleared out references to it in stanmodels.R, rmot.rmd.

* Updated ignore to exclude compiled binaries.

* Cleared out .o and .so files.

* Added develop branch as a trigger for PR

---------

Co-authored-by: Fonti Kar <[email protected]>
@Tess-LaCoil Tess-LaCoil requested a review from fontikar October 19, 2023 22:35
Copy link
Member

@dfalster dfalster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

You need to add tests checking that models run !

Also good to add tests checking that they fail when you add the wrong inputs

@Tess-LaCoil
Copy link
Collaborator Author

Nice work.

You need to add tests checking that models run !

Also good to add tests checking that they fail when you add the wrong inputs

Okay, I'll need to do those for the multiple individuals as well then. I thought we were going to do them as a collection once Fonti was back. Happy to set up stuff and wait for then. Is it possible to have multiple concurrent branches each one implementing a different model or should they be done one at a time?

@dfalster
Copy link
Member

I didn't know you already had a plan.

Generally I suggest adding tests at the time.

@dfalster
Copy link
Member

For inspiration, take a look at sizedist package

https://github.com/traitecoevo/sizedist/tree/master/tests/testthat

@fontikar
Copy link
Collaborator

fontikar commented Apr 3, 2024

Let's close this PR to avoid confusion, as we have established a new workflow on the constant branch. Closing will not delete the constant_single_individual branch

@fontikar fontikar closed this Apr 3, 2024
@fontikar fontikar deleted the constant_single_individual branch April 8, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants