-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constant single individual #6
Conversation
* Updated notation and function structure in the multi individual constant model file for consistency. Updated rmot_run, rmot_models to reflect the changes. * Removed old constant stan file and cleared out references to it in stanmodels.R, rmot.rmd. * Updated ignore to exclude compiled binaries. * Cleared out .o and .so files. * Added develop branch as a trigger for PR --------- Co-authored-by: Fonti Kar <[email protected]>
…nette. Need to do test files yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
You need to add tests checking that models run !
Also good to add tests checking that they fail when you add the wrong inputs
Okay, I'll need to do those for the multiple individuals as well then. I thought we were going to do them as a collection once Fonti was back. Happy to set up stuff and wait for then. Is it possible to have multiple concurrent branches each one implementing a different model or should they be done one at a time? |
I didn't know you already had a plan. Generally I suggest adding tests at the time. |
For inspiration, take a look at sizedist package https://github.com/traitecoevo/sizedist/tree/master/tests/testthat |
…gle/y_multi in global environment not being seen within rmot_assign_data function.
…functions, y_single and y_multi are not evaluated globally #1
…functions, y_single and y_multi are not evaluated globally #1
…ecoevo/rmot into constant_single_individual
…y for single and multiple individuals. Tests all complete dynamically and when run in the testing console.
…n function to account for a list not being suitably interpreted as vector in building data frame.
…nham tests run in console and dynamically.
…eep everything consistent.
Let's close this PR to avoid confusion, as we have established a new workflow on the |
Added stan file, data template, and data template testing for the constant model with a single individual. Also tidied up some of the code and comments so that the single and multiple individuals for the constant model would be more clearly matched.