You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move custom expect_ functions out of dataset_test, into R/test_functions.R so that R CMD check warnings are removed (otherwise "no visible global function definition" warning comes up)
Rename prefixes to test_expect_ to differentiate between custom testthat functions and built-in testthat functions
I kept using expect_silent() from {testthat} instead of writing a custom function because I'm not sure how to rewrite the function to capture messages on top of errors and warnings
@dfalster I should have explained clearer but basically R/test_functions.R contains 'custom' expect_ functions, now named test_expect_ functions, which allow you to customise the failure message. The inbuilt expect_ functions from {testthat} do not allow full customisation of failure messages. I have used the test_expect_ functions only in dataset_test(), and the rest of the tests use {testthat} inbuilt functions. Hope that makes sense!
@dfalster I should have explained clearer but basically R/test_functions.R contains 'custom' expect_ functions, now named test_expect_ functions, which allow you to customise the failure message. The inbuilt expect_ functions from {testthat} do not allow full customisation of failure messages. I have used the test_expect_ functions only in dataset_test(), and the rest of the tests use {testthat} inbuilt functions. Hope that makes sense!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dataset_testandtests#131expect_functions out ofdataset_test, into R/test_functions.R so that R CMD check warnings are removed (otherwise "no visible global function definition" warning comes up)test_expect_to differentiate between customtestthatfunctions and built-intestthatfunctionsexpect_silent()from {testthat} instead of writing a custom function because I'm not sure how to rewrite the function to capture messages on top of errors and warnings