Error if no contexts #154
Merged
Error if no contexts #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solves issue #150
Remove check for units in unit_conversions - this isn't expected. The `unit_in` field can also be a data.csv column. Or there can be units that are used, but happen to not be in the unit_conversions because there aren't any instances where they require converting. Noted in issue #146 as well.
dfalster
approved these changes
Apr 9, 2024
ehwenk
added a commit
that referenced
this pull request
Dec 19, 2024
- traits.build paper published in Sep 2024 in Ecological Informatics (DOI: 10.1016/j.ecoinf.2024.102773)
- Minor updates to ontology, which is now version 1.0.0
- Added standard error and standard deviation as value types
Moved functions to austraits package and made austraits package a dependancy
Renamed some of the functions that are now moved to austraits package
bind_databases <-- build_combine
convert_df_to_list <-- util_df_to_list
convert_list_to_df1 <-- util_list_to_df1
convert_list_to_df2 <-- util_list_to_df2
Renamed functions still also assigned their old name, with a deprecation warning indicating the new name
plot_trait_distribution_beeswarm, trait_pivot_longer and trait_pivot_wider had been in both austraits and traits.build packages and have now been removed from traits.build
Import new austraits function flatten_database (had been suggested to be database_create_combined_table)
Refactoring of test functions used by dataset_test
Added tests using the dataset_test function, so it is checked explicitly by traits.build (run on Example datasets)
Minor bug fixes
Issues addressed since last traits.build release:
Issue #150 & Issue #154 (error if no contexts)
Issue #179 (incorrect test written that flagged an error if input/output units identical)
Issue #171 (SE required as a value type)
Issue #131 (remove duplicate functions)
Issue #183 (deprecated function still being used)
Issue #185 (context table columns mis-ordered, dataset test failing)
Issue #143 (add dataset_test tests)
---------
Co-authored-by: Daniel Falster <[email protected]>
Co-authored-by: Fonti Kar <[email protected]>
Co-authored-by: Sophie Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing two small tests errors:
Should merge in, because I'd already forgotten I'd fixed the contexts error once and just did it a second time...