Fix time data types in contexts getting reformatted #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Gets added to metadata files, where the default is set to false (otherwise this will mask the need for contexts to pivot) * Not yet tested in process.R- waiting to merge in other branches first
- repeat_measurements_id is now a column of NA's in austraits$traits - however, don't have it working to be triggered at either the dataset or trait level - in schema - at this point need to change line ` i <- !is.na(data$value) & !is.na(data$repeat_measurements_id)` (or elsewhere) to have it recognise when `repeat_measurements_id: TRUE` (or `y`) is added to either metadata$dataset or specific traits in metadata
- Set `repeat_measurements_id` to TRUE in the metadata
… a trait is entered twice
…n from locations Otherwise population_id, observation_id, etc. are made before `entity_type` and other metadata fields are finalised
…text values to character type - The latter prevents time data types from converting weirdly when converted to yaml
|
@dfalster This is ready for review :) Thank you! |
dfalster
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #49
read_csv, because it detects the column data type when reading in, such that e.g. "9:00:00" becomes "09:00:00". This is not too much of an issue if it's consistent with the output ofmetadata_add_contextsandprocess.R. However,metadata_add_contextswas rewriting "09:00:00" as total number of seconds: "32400.0"write_metadatadoes not convert times to number of secondsdataset_test