Remove Msg::None and remove some clones
#410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also document all "DLMsg"
To be more explicit than "None". There are a bunch of places "None" can be replaced with "ForceRedraw", but only if necessary.
…ForceRedraw" But only when necessary. Replaces "Msg::None" usage.
…Redraw" But only when necessary. Replaces "Msg::None" usage.
… "Msg::ForceRedraw" But only when necessary. Replaces "Msg::None" usage.
…or "Msg::ForceRedraw" But only when necessary. Replaces "Msg::None" usage.
…or "Msg::ForceRedraw" But only when necessary. Replaces "Msg::None" usage.
…orceRedraw" But only when necessary. Replaces "Msg::None" usage.
…r "Msg::ForceRedraw" But only when necessary. Replaces "Msg::None" usage.
… or "Msg::ForceRedraw" But only when necessary. Replaces "Msg::None" usage.
…or "Msg::ForceRedraw" But only when necessary. Replaces "Msg::None" usage.
…" or "Msg::ForceRedraw" But only when necessary. Replaces "Msg::None" usage.
… "Msg::ForceRedraw" But only when necessary. Replaces "Msg::None" usage.
…Redraw" But only when necessary. Replaces "Msg::None" usage.
…edraw" But only when necessary. Replaces "Msg::None" usage.
…::ForceRedraw" But only when necessary. Replaces "Msg::None" usage.
… "Msg::ForceRedraw" But only when necessary. Replaces "Msg::None" usage.
…one" or "Msg::ForceRedraw" But only when necessary. Replaces "Msg::None" usage.
…turn "None" or "Msg::ForceRedraw" But only when necessary. Replaces "Msg::None" usage.
…"None" or "Msg::ForceRedraw" But only when necessary. Replaces "Msg::None" usage.
…raw" But only when necessary. Replaces "Msg::None" usage.
Either use "ForceRedraw" or "Option::None"
…nents that use "Textarea" see veeso/tui-realm-stdlib#27
hasezoey
force-pushed
the
removeMsgNone
branch
from
ead70c0 to
d7a3a12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
Msg::Noneand replace it withOption::NoneorMsg::ForceRedrawwhere necessaryYoutubeSearch*variants fromDLMsgtoYSMsgXYWHMsg::HidetoToggleHiddenplayback::playlist::swap_downwhen the playlist is emptyDraft until #407 is merged and clippy is re-runAlso related is veeso/tui-realm-stdlib#27