Refactor & document playlist-related things #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…list_add" functions
…es not exist or is empty
instead of turning them into paths
…directly instead of buffering everything again
…st is empty and dont write anything else
…instead of "remove" & "insert" "remove" and "insert" will move all the data and may allocate, whereas "swap" literally swaps in-place.
and remove useless case
…rack" and report errors move single-add track to own function and report any errors instead of silently failing. Now "invalid file type" errors are actually caught (not when symphonia or so fails though yet).
…p with 0 or 1 elements
as it was basically never used, and "next_track_index" can fully serve the use-case. Also always use "next_track_index" if available, not just when "gapless". Finally, remove field "config" as it is now never used.
…exposing this function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors & documents playlist-related things, in more details:
tui::components::playlist::playlist_add_*functionsplayback::playlist::Playlistfields & functionsPlaylist::get_random_indexPlaylist::add_track/Playlist::add_playlistinstead of silently ignoring them (like "unsupported file type")playlist.logif file did not exist or is empty0toplaylist.logif the playlist is empty, only truncate the filePlaylist::clearinstead of having some residual dataPlaylist::next_trackand only usePlaylist::next_track_index.vscodedirectorySome optimizations:
Playlist::savewrite toBufWriterdirectly, instead of into a intermediate bufferPlaylist::swap_*useVec::swapinstead of removing & inserting