MAIN - B-22251 Update existing process for approving move and shipment #14702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment approval and added tests
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller
Unchanged
|
WeatherfordAaron
deleted the
MAIN-B-22251-defect-update-existing-process-approving
branch
deandreJones
restored the
MAIN-B-22251-defect-update-existing-process-approving
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-22251
INT PR:
#14704
#14728 (This change was to fix a test that got merged in after mine. This change can be added to #14630 if this PR gets merged in first.)
Summary
Issues:
This fixes several production defects that occur when a TOO approves a move or shipment (sending it to Prime). The issues were primarily caused by race conditions between API calls and database updates. Additionally, the 'available to prime' field was being set during the move approval process, but this approach doesn't work because shipment service items are created later—during the shipment approval step, which happens after the move approval.
To address issue 1:
Move was being made available to prime when a move is approved but before service items were created. In between those times, the prime could be pulling in the data without items attached.
approveShipmentsGHC api that takes in array of objects containingshipmentIDandeTagand approve one or more shipments in one api call if allowed.availableToPrimeAtinMakeAvailableToPrimeand made it it's own function which is now being called in theapproveShipmentandapproveShipmentsapi. Also moved other related codes.availableToPrimeAtis now being called and being populated after move and shipment has been approved.To address issues 2 & 3:
Mostly race condition issues with the status getting updated by other db changes.
ApproveOrRequestApprovalfunc call at the end of creating service items which checks and sets the move status.How to test
APPROVALS REQUESTEDunder move object.APPROVED.availableToPrimeAtvalue somewhere in your notes.mto_service_itemsin dev tools shown in the screenshot and check all thecreatedAttimestamp for all the service items and verify thatavailableToPrimeAthas the latest timestamp. (NOTE: the move history will not have the list in order so verify with timestamps.)APPROVED.Screenshots