-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INT - B-22300 - add dependents authorized to orders page #14803
Merged
taeJungCaci
merged 8 commits into
integrationTesting
from
INT-B-22300-add-dependents-authorized-to-orders-page
Feb 14, 2025
Merged
INT - B-22300 - add dependents authorized to orders page #14803
taeJungCaci
merged 8 commits into
integrationTesting
from
INT-B-22300-add-dependents-authorized-to-orders-page
Feb 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into INT-B-22300-add-dependents-authorized-to-orders-page
…into INT-B-22300-add-dependents-authorized-to-orders-page
…horized-to-orders-page
…horized-to-orders-page
…horized-to-orders-page
ryan-mchugh
approved these changes
Feb 13, 2025
KonstanceH
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested as SC/TOO and ran local server test and everything looks good to me. LGTM!
paulstonebraker
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷
…horized-to-orders-page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-22300
Summary
This is to move
Dependents authorized
checkbox that is inView Allowances
page toView Orders
page for office users . Also movesDependents
label from the Allowances list card to Orders list card in Move Details page. ThedependentsAuthorized
value is now being sent in updating orders api payload and removed from allowances. Also fixed a couple of failing playwright tests for boats.How to test
Dependents authorized
checkbox is visible and editable under edit orders.Dependents authorized
is gone.Dependents authorized
-> then save -> and verify that the value is being saved correctly and that result is shown in Orders section in Move details page asDependents
label. This label should be gone from Allowances section. Checked box ==Authorized
, unchecked box ==Unauthorized
.Screenshots