Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT - B-22300 - add dependents authorized to orders page #14803

Conversation

taeJungCaci
Copy link
Contributor

@taeJungCaci taeJungCaci commented Feb 12, 2025

B-22300

Summary

This is to move Dependents authorized checkbox that is in View Allowances page to View Orders page for office users . Also moves Dependents label from the Allowances list card to Orders list card in Move Details page. The dependentsAuthorized value is now being sent in updating orders api payload and removed from allowances. Also fixed a couple of failing playwright tests for boats.

How to test

  1. as a customer -> create any move with any shipment.
  2. as SC -> edit orders and verify that Dependents authorized checkbox is visible and editable under edit orders.
  3. Check Allowances page and verify that Dependents authorized is gone.
  4. Edit orders and edit Dependents authorized -> then save -> and verify that the value is being saved correctly and that result is shown in Orders section in Move details page as Dependents label. This label should be gone from Allowances section. Checked box == Authorized, unchecked box == Unauthorized.
  5. Submit the move to TOO and repeat the process to make sure it works for TOO.

Screenshots

image
image
image

@taeJungCaci taeJungCaci added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Feb 12, 2025
@taeJungCaci taeJungCaci self-assigned this Feb 12, 2025
@taeJungCaci taeJungCaci marked this pull request as ready for review February 12, 2025 21:10
@taeJungCaci taeJungCaci requested review from a team as code owners February 12, 2025 21:10
@ryan-mchugh
Copy link
Contributor

ryan-mchugh commented Feb 13, 2025

Local Testing

image image image

TOO
image
unchecked
image

Copy link
Contributor

@KonstanceH KonstanceH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as SC/TOO and ran local server test and everything looks good to me. LGTM!

Copy link
Contributor

@paulstonebraker paulstonebraker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@taeJungCaci taeJungCaci merged commit c084820 into integrationTesting Feb 14, 2025
6 checks passed
@taeJungCaci taeJungCaci deleted the INT-B-22300-add-dependents-authorized-to-orders-page branch February 14, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

4 participants