Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-21941 INT #14810

Merged
merged 30 commits into from
Feb 13, 2025
Merged

B-21941 INT #14810

merged 30 commits into from
Feb 13, 2025

Conversation

traskowskycaci
Copy link
Contributor

@traskowskycaci traskowskycaci commented Feb 13, 2025

Agility ticket

First INT PR: #14465
Second INT PR: #14586

Upstream branches:

Test moves:

Please go through the process of making an actual move if you use a test harness move and it's not appearing in the origin or destination queues as expected or acting weird.

I found the test harness moves to not be 100% reliable, so I ended up making my own test moves for these - and will keep the moves locally and can huddle if any questions come up.

This work is to filter moves OUT of the origin TOO queue queue if they have ONLY destination requests. The test will be moves filtered out of the TOO queue, but I threw in what the destination queue behavior should be as an additional check, though this work doesn't touch destination queue logic (those are B-22272 and B-22451).

  • One with only destination address update - should NOT appear in TOO queue and should appear in destination queue: 66K9TX
    destination:
    image
    origin:
    image

  • One that has only origin SIT - should appear in TOO queue: HD7746
    destination:
    image
    origin:
    image

  • One that has only dest SIT - should NOT appear in TOO queue and should appear in destination queue: PJJQR7
    destination:
    image
    origin:
    image

  • One that has BOTH origin and dest SIT - should appear in TOO queue and should appear in destination queue: V6PGXF
    destination:
    image
    origin:
    image

  • One that has only domestic origin shuttle - should appear in TOO queue: DJKD8R
    destination:
    image
    origin:
    image

  • One that has only dest shuttle - should NOT appear in TOO queue and should appear in destination queue: 48PX4B
    image
    origin:
    image

  • One that has BOTH origin and dest shuttle - should appear in TOO queue and should appear in destination queue: YM6KHF
    destination:
    image
    origin:
    image

  • One that has only intl origin shuttle - should appear in TOO queue: 9BM93K
    destination:
    image
    origin:
    image

  • One that has only intl destination shuttle - should appear in dest queue: MGR43H
    destination:
    image
    origin:
    image

  • One that has BOTH intl origin and intl dest shuttle - should appear in TOO queue and should appear in destination queue: BMQHX4
    destination:
    image
    origin:
    image

  • One that has excess weight - should appear in TOO queue: KWH4RD
    destination:
    image
    origin:
    image

  • One that has excess UB weight - should appear in TOO queue: QT844H
    destination:
    image
    origin:
    image

  • Test that the moves with excess weight only show up in the expected GBLOC office user TOO queue and not every other GBLOC's TOO queue: (relic of the old query that was an issue but should not be now)
    shown in KKFA queue above
    not in BGNC:
    image
    image
    not in CCNQ:
    image
    image

Changes since last review: logic around SIT extensions

  • One that has a SIT extension and only origin SIT - should appear in TOO queue: D3PBPJ
    destination:
    image
    origin:
    image

  • One that has a SIT extension and only dest SIT - should appear in dest queue: KCMJVB
    destination:
    image
    origin:
    image

  • One that has a SIT extension and both origin and dest SIT - should appear in both queues: QGFJ7X
    destination:
    image
    origin:
    image

@traskowskycaci traskowskycaci self-assigned this Feb 13, 2025
@traskowskycaci traskowskycaci added the Mountain Movers Movin' Mountains 1 Sprint at a time label Feb 13, 2025
Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man. What a beaut. I really hope this does the trick! Ready to leave this destination queue alone for a while.

Tested like, every single scenario I could think of and seems like things are gucci!

@traskowskycaci
Copy link
Contributor Author

Holding off on merging into integrationTesting until the pipelines failures are resolved

@traskowskycaci
Copy link
Contributor Author

Holding off on merging into integrationTesting until the pipelines failures are resolved

Issue resolved, merging

@traskowskycaci traskowskycaci merged commit 626f53d into integrationTesting Feb 13, 2025
5 checks passed
@traskowskycaci traskowskycaci deleted the B-21941-INT-v3 branch February 13, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

3 participants