-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B-21941 INT #14810
B-21941 INT #14810
Conversation
…review" This reverts commit bf88d94.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man. What a beaut. I really hope this does the trick! Ready to leave this destination queue alone for a while.
Tested like, every single scenario I could think of and seems like things are gucci!
Holding off on merging into integrationTesting until the pipelines failures are resolved |
Issue resolved, merging |
Agility ticket
First INT PR: #14465
Second INT PR: #14586
Upstream branches:
22272
main branch: https://github.com/transcom/mymove/tree/MAIN-B-22272
22451
main branch: https://github.com/transcom/mymove/tree/MAIN-B-22451
Test moves:
Please go through the process of making an actual move if you use a test harness move and it's not appearing in the origin or destination queues as expected or acting weird.
I found the test harness moves to not be 100% reliable, so I ended up making my own test moves for these - and will keep the moves locally and can huddle if any questions come up.
This work is to filter moves OUT of the origin TOO queue queue if they have ONLY destination requests. The test will be moves filtered out of the TOO queue, but I threw in what the destination queue behavior should be as an additional check, though this work doesn't touch destination queue logic (those are B-22272 and B-22451).
One with only destination address update - should NOT appear in TOO queue and should appear in destination queue: 66K9TX


destination:
origin:
One that has only origin SIT - should appear in TOO queue: HD7746


destination:
origin:
One that has only dest SIT - should NOT appear in TOO queue and should appear in destination queue: PJJQR7


destination:
origin:
One that has BOTH origin and dest SIT - should appear in TOO queue and should appear in destination queue: V6PGXF


destination:
origin:
One that has only domestic origin shuttle - should appear in TOO queue: DJKD8R


destination:
origin:
One that has only dest shuttle - should NOT appear in TOO queue and should appear in destination queue: 48PX4B


origin:
One that has BOTH origin and dest shuttle - should appear in TOO queue and should appear in destination queue: YM6KHF


destination:
origin:
One that has only intl origin shuttle - should appear in TOO queue: 9BM93K


destination:
origin:
One that has only intl destination shuttle - should appear in dest queue: MGR43H


destination:
origin:
One that has BOTH intl origin and intl dest shuttle - should appear in TOO queue and should appear in destination queue: BMQHX4


destination:
origin:
One that has excess weight - should appear in TOO queue: KWH4RD


destination:
origin:
One that has excess UB weight - should appear in TOO queue: QT844H


destination:
origin:
Test that the moves with excess weight only show up in the expected GBLOC office user TOO queue and not every other GBLOC's TOO queue: (relic of the old query that was an issue but should not be now)




shown in KKFA queue above
not in BGNC:
not in CCNQ:
Changes since last review: logic around SIT extensions
One that has a SIT extension and only origin SIT - should appear in TOO queue: D3PBPJ


destination:
origin:
One that has a SIT extension and only dest SIT - should appear in dest queue: KCMJVB


destination:
origin:
One that has a SIT extension and both origin and dest SIT - should appear in both queues: QGFJ7X


destination:
origin: