Main b 21659 display estimated prices ub #14811
Merged
+68
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add UB prop type to ShipmentDisplay Add UB prop type to ShipmentInfoListSelector
add case for UBP add case for PODFSC add case for POEFSC add case for IUBUPK add case for IUBPK add case for IHUPK add case for IHPK add case for ISLH add case for DUPK
msaki-caci
requested review from
danieljordan-caci,
brianmanley-caci,
elizabeth-perkins,
samaysofo,
ryan-mchugh,
stevengleason-caci and
a team
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
commits match up, approved! |
ryan-mchugh
approved these changes
Feb 13, 2025
danieljordan-caci
approved these changes
Feb 13, 2025
brianmanley-caci
approved these changes
Feb 13, 2025
brianmanley-caci
deleted the
MAIN-B-21659_Display_estimated_prices_UB
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21659
INT PR
Summary
When we order basic iUB service items, we also want the ability to see the estimated price when we have the estimated weight on the shipment. In order to do this, the UI has to allow the estimated price section show for iUB service items AND we have to populate the pricing_estimate data any time that pertinent data is provided and/or changed.
A lot of the work was done with this PR here #14528
So I also used this BL to fix some of the warnings that were mentioned here #14557 (review)
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests
How to test
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots