B 22764 int #14921
Open
B 22764 int #14921
+53
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B-22227 Prime API address validation
Update .gitlab-ci.yml
…uthorized-to-orders-page MAIN - B-22300 - add dependents authorized to orders page
MAIN B-22661
disable bookmark extraction in tests
loganwc
requested review from
paulstonebraker,
joeydoyecaci,
pambecker and
JonSpight
pambecker
approved these changes
Mar 3, 2025
| if !userFound { | ||
| availableOfficeUsers = append(availableOfficeUsers, *move.TOOAssignedUser) | ||
|
|
||
| if assignedUser != nil { |
There was a problem hiding this comment.
does it make more sense to move this check back to 2409 and skip this block entirely if there is no assigned user?
| @@ -139,7 +139,10 @@ func (o *officeUserFetcherPop) FetchOfficeUsersWithWorkloadByRoleAndOffice(appCt | |||
| office_users.last_name, | |||
| COUNT(DISTINCT moves.id) AS workload | |||
| FROM office_users | |||
| JOIN users_roles ON office_users.user_id = users_roles.user_id | |||
| JOIN users_roles | |||
| ON ( | |||
There was a problem hiding this comment.
any reason for parens here? I think I'd prefer
JOIN users_roles
ON office_users.user_id = users_roles.user_id
AND users_roles.deleted_at IS NULL
but not sure there is a difference performance wise and maybe its just a style thing... won't block for this 🙃
|
not sure why but test passes with deleted stuff commented out on my local |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
Summary
This fixes two bugs, first bulk assignment modal no longer displays users who had that respective role deleted.
Second fix is when a services counselor is assigned to a move and their role is deleted they will still be visible in the dropdown until someone else is assigned.
How to test