Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT B-22654 #14934

Open
wants to merge 9 commits into
base: integrationTesting
Choose a base branch
from
Open

INT B-22654 #14934

wants to merge 9 commits into from

Conversation

danieljordan-caci
Copy link
Contributor

Agility ticket

Note

This branch contains the code of B-22653 so please ensure that is merged prior to this one once POA'd

Summary

Here we are setting up the groundwork for a new type of PPM called "Small Package Reimbursement". With the work of B-22653, we now have the database changes and feature flag additions that we need to start work.

This PR specifically focuses on the PPM creation/updating process for the following scenarios:

  • customer creating a PPM shipment
  • customer created PPMs should have a default ppm_type of INCENTIVE_BASED if they are NOT civilian employees
  • customer created PPMs should have a default ppm_type of ACTUAL_EXPENSE if they ARE civilian employees
  • if the customer edits their orders after PPM creation and changes their pay grade FROM CIVILIAN_EMPLOYEE or TO CIVILIAN_EMPLOYEE, the ppm_type needs to be updated if the PPM is still in DRAFT status
  • the customer can then edit their PPM freely but should not even know what kind of PPM type they have because we aren't showing that to them - only the SC
  • once it gets to the SC, we want to let them choose the PPM type (note: we are removing the previous actual reimbursement block since it is being covered in the type selection)
  • SC should be able to edit the PPM types (civilians should have a disabled Incentive-based option)
  • should be able to download the AOA packet and see the SPR values on that PDF

How to test

  1. Make sure you turn on the FEATURE_FLAG_PPM_SPR flag in your envrc
  2. Fire up your client & server
  3. Go through setting up a PPM as a service member (not a civilian), nothing should be changed here and shouldn't get any errors
  4. Submit the PPM
  5. Go in as SC and review the PPM - you should now see an option to designate the PPM as other options (Actual Expense & Small Package)
  6. Confirm that the Incentive-based option is checked by default
  7. Play around with it, you should see some labels change when you select Small Package Reimbursement
  8. Make sure you can successfully update any PPM of any type as SC
  9. Make sure you can do the same as TOO (note: TOOs do not see the PPM type designator)
  10. Set up a PPM that gets an advance so you can download the AOA packet
  11. Review the AOA packet and make sure you can see the specific Small Package changes on the SSW
  12. Go through this same process with an actual expense reimbursement and make sure nothing is broken
  13. Go through the same process with incentive-based and make sure nothing is broken
  14. Now repeat these steps with the pay grade Civilian Employee and confirm that SCs cannot select Incentive-based for civilians
  15. Turn the FEATURE_FLAG_PPM_SPR off and make sure all is good and no small package things (on the UI side) cannot be seen

Screenshots

Non-civilian incentive-based
Screenshot 2025-02-27 at 10 35 28 AM

Non-civilian actual expense
Screenshot 2025-02-27 at 10 35 09 AM

Non-civilian small package
Screenshot 2025-02-27 at 10 35 14 AM

Civilian actual expense
Screenshot 2025-02-27 at 11 08 11 AM

Civilian small package
Screenshot 2025-02-27 at 11 08 16 AM

Screenshot 2025-03-03 at 1 38 16 PM Screenshot 2025-03-03 at 1 38 22 PM Screenshot 2025-03-03 at 1 38 27 PM Screenshot 2025-03-03 at 1 38 40 PM

@danieljordan-caci danieljordan-caci added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Mar 3, 2025
@danieljordan-caci danieljordan-caci requested review from paulstonebraker, loganwc and a team March 3, 2025 20:33
@danieljordan-caci danieljordan-caci self-assigned this Mar 3, 2025
@danieljordan-caci danieljordan-caci requested review from a team as code owners March 3, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

1 participant