Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
Note
This branch contains the code of B-22653 so please ensure that is merged prior to this one once POA'd
Summary
Here we are setting up the groundwork for a new type of PPM called "Small Package Reimbursement". With the work of B-22653, we now have the database changes and feature flag additions that we need to start work.
This PR specifically focuses on the PPM creation/updating process for the following scenarios:
ppm_type
ofINCENTIVE_BASED
if they are NOT civilian employeesppm_type
ofACTUAL_EXPENSE
if they ARE civilian employeesCIVILIAN_EMPLOYEE
or TOCIVILIAN_EMPLOYEE
, theppm_type
needs to be updated if the PPM is still inDRAFT
statusIncentive-based
option)How to test
FEATURE_FLAG_PPM_SPR
flag in yourenvrc
client
&server
Actual Expense
&Small Package
)Incentive-based
option is checked by defaultSmall Package Reimbursement
Civilian Employee
and confirm that SCs cannot selectIncentive-based
for civiliansFEATURE_FLAG_PPM_SPR
off and make sure all is good and no small package things (on the UI side) cannot be seenScreenshots
Non-civilian incentive-based

Non-civilian actual expense

Non-civilian small package

Civilian actual expense

Civilian small package
