Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform independence + some improvements #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JLanda91
Copy link

  • Reformatted the file to PEP standards
  • refactored path joins to work on any platform
  • Fixed BeautifulSoup warning on urlopen

@JLanda91
Copy link
Author

JLanda91 commented Aug 20, 2022

More improvements:

  • url validation (use startswith BASE_URL)
  • use f-strings
  • Deleted first dir exists check, since the second will create all intermediate folders if needed

@jmc718
Copy link

jmc718 commented Oct 18, 2024

This fixed OS errors I was having.

Python WindowsError: [Error 123] The filename, directory name, or volume label syntax is incorrect:

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants