Improve mypy checking #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnasbr
commented
Sep 12, 2024
Comment on lines
+53
to
54
| mypy --install-types --non-interactive . | ||
| mypy . |
There was a problem hiding this comment.
first we run mypy just to see what types need to be installed, and install those types. Then we do the actual run
arnasbr
commented
Sep 12, 2024
| @@ -42,6 +42,7 @@ test = [ | |||
| "flake8-pyproject", | |||
| "mypy", | |||
| "black", | |||
| "types-shapely", | |||
There was a problem hiding this comment.
shapely types aren't installed by default with the --install-types flag, so I install them explicitly for CI
arnasbr
commented
Sep 12, 2024
| @@ -58,7 +59,6 @@ extend-ignore = ["E203"] # See https://github.com/Py | |||
| exclude = ["build/", "venv/", "traveltimepy/proto/"] | |||
|
|
|||
| [tool.mypy] | |||
| ignore_missing_imports = true | |||
There was a problem hiding this comment.
we no longer need to ignore missing imports
arnasbr
commented
Sep 12, 2024
| @@ -68,7 +68,7 @@ def _parse_polygon(geometry: Polygon) -> PolygonModel: | |||
| PointModel(coordinates=Coordinates(lat=lat, lng=lng)) | |||
| for lat, lng in interior.coords | |||
| ] | |||
| for interior in geometry.interiors | |||
| for interior in list(geometry.interiors) | |||
There was a problem hiding this comment.
fixing error
Item "List[LinearRing]" of "Union[Iterator[LinearRing], List[LinearRing]]" has no attribute "__next__" [union-attr]
danielnaumau
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.