Adding time-map-fast json and geojson #145
Conversation
| * [transportation](#transportation): Union - Transportation mode and related parameters. | ||
| * [transportation]: Transportation - Transportation mode and related parameters. |
There was a problem hiding this comment.
fast endpoints have different transportation types, so this part of time-filter-fast description is incorrect, maybe I'll add a readme entry for them too
| coords=cur_coordinates, | ||
| transportation=transportation, | ||
| travel_time=travel_time, | ||
| arrival_time_period="weekday_morning", # TODO: make customizable with enum / literal |
There was a problem hiding this comment.
time filter fast has this hardcoded, so keeping it like this for now. Will make it customizable (a literal to avoid breaking changes) in the future
There was a problem hiding this comment.
not necessarily a literal, but it has to be optional, with default value of "weekday_morning"
| class Transportation(BaseModel): | ||
| type: Literal[ | ||
| "public_transport", | ||
| "driving", | ||
| "cycling", | ||
| "walking", | ||
| "walking+ferry", | ||
| "cycling+ferry", | ||
| "driving+ferry", |
There was a problem hiding this comment.
Removing modes that are unsupported by our api anymore, tho this would be a breaking change. Let me know if I should keep it.
There was a problem hiding this comment.
nvm I'll undo this. driving, cycling and walking is not mentioned in our api docs, but no error is thrown if they're used, so someone might be using them
Adding json and geojson first as those are the most needed.
Skipping params that the sdk doesn't support yet (like
render_mode). Will add them in future PRs.