Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add publish.yml GitHub Action job to upload urdfdom-py to PyPI #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add publish.yml GitHub Action job to upload urdfdom-py to PyPI #1

wants to merge 1 commit into from

Conversation

traversaro
Copy link
Owner

Implement ros/urdf_parser_py#85 (comment) . The package will be uploaded as soon as we tag a v1.2.1 release.

haixuanTao
haixuanTao reviewed Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@haixuanTao haixuanTao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just aded macOS as I'm planning to use it on my Mac. :)

.github/workflows/publish.yml
Comment on lines +21 to +22
- ubuntu-24.04

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ubuntu-24.04
- ubuntu-24.04
- macos-latest

this should be okay

.github/workflows/publish.yml
Comment on lines +49 to +50
name: Deploy to PyPI
runs-on: ubuntu-24.04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Deploy to PyPI
runs-on: ubuntu-24.04
name: Deploy to PyPI
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
python-version:
- 3.11
os:
- ubuntu-24.04
- macos-latest

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wheel is pure python, so I do not think we do not need to publish a different one for each os, just uploading it on Linux is fine and will produce a package that should work fine also on macos.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok! I wasn't sure about this, but you're probably right

@traversaro
Copy link
Owner Author

I tried to do a test upload to TestPyPI with Trusted Publishers in the https://github.com/traversaro/urdfdom-py-pypi/tree/staging branch, with all the releases in https://github.com/traversaro/urdfdom-py-pypi/releases . However, the upload somehow is failing with:


SHA256: 1a5a9b8a08452a64c9e25c4163bb7a3d062e61522aa135ce4e7e85cd9fc919da
MD5: 3ae60a82bfed709a5647f3c406ae6591
BLAKE2-256: 8c4d7513ea918de04606dcc25f733237dc8ca8a1c84610f7f5a296b3e5734802

WARNING  Only PyPI and TestPyPI support attestations; if you experience         
         failures, remove the --attestations flag and re-try this command       
Uploading distributions to https://test.pypi.org/legacy
INFO     dist/urdfdom_py-1.2.1-py3-none-any.whl (16.6 KB)                       
INFO     dist/urdfdom_py-1.2.1.tar.gz (18.1 KB)                                 
INFO     username set by command options                                        
INFO     password set by command options                                        
INFO     username: __token__                                                    
INFO     password: <hidden>                                                     
Uploading urdfdom_py-1.2.1-py3-none-any.whl
INFO     Response from https://test.pypi.org/legacy:                            
         400 Bad Request                                                        
INFO     <html>                                                                 
          <head>                                                                
           <title>400 Bad Request</title>                                       
          </head>                                                               
          <body>                                                                
           <h1>400 Bad Request</h1>                                             
           The server could not comply with the request since it is either      
         malformed or otherwise incorrect.<br/><br/>                            
         POST body may not contain duplicate keys (URL:                         
         &#x27;https://test.pypi.org/legacy&#x27;)                              
                                                                                
                                                                                
          </body>                                                               
         </html>                                                                
ERROR    HTTPError: 400 Bad Request from https://test.pypi.org/legacy           
         Bad Request

I am not sure what is going on @haixuanTao if you want to look on that I gave you access to both the repo and the TestPyPI urdfdom-py project.

@traversaro
Copy link
Owner Author

I am not sure what is going on @haixuanTao if you want to look on that I gave you access to both the repo and the TestPyPI urdfdom-py project.

Actually I could not found you on TestPyPI, do you have a user there (if I recall correctly the users are separated from PyPI).

@haixuanTao
Copy link
Collaborator

Lol, I'm not on test pypi. Let me create an account.

@haixuanTao
Copy link
Collaborator

There you go: https://test.pypi.org/user/haixuantao/

@traversaro
Copy link
Owner Author

I think you need some setting, now it gives me an error:

Error User 'haixuantao' does not have a verified primary email address and cannot be added as a Maintainer for project

@haixuanTao
Copy link
Collaborator

Indeed. I just verified it.

I think the issue with the CI is probably around how to pass the credentials. What I usually do is pass the credendials within a GitHub secret as an env variable.

@traversaro
Copy link
Owner Author

I think the issue with the CI is probably around how to pass the credentials. What I usually do is pass the credendials within a GitHub secret as an env variable.

Yes, I was trying to set up Trusted Publishers to avoid setting the secrets, as it worked in other repos. But whatever works is fine for me. I added you on TestPyPI.

@haixuanTao
Copy link
Collaborator

So, I don't think I can add secret on this GitHub project. FYI.

@traversaro
Copy link
Owner Author

So, I don't think I can add secret on this GitHub project. FYI.

Ah, annoying, I can't make you admin of a personal repo. Let me add the token myself.

@traversaro
Copy link
Owner Author

So, I don't think I can add secret on this GitHub project. FYI.

Ah, annoying, I can't make you admin of a personal repo. Let me add the token myself.

I created the PYPI_TOKEN (for PyPI) and TEST_PYPI_TOKEN (for TestPyPI) secrets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haixuanTao haixuanTao haixuanTao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traversaro @haixuanTao