Delay extending Rails until loaded #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When extending Rails, instrumentation should be used to wait until the component being extended is fully loaded. Without this, it triggers the loading early through the autoloader which can lead to other problems. For more background see rails/rails#36546.
|
Failures look like they are due to mocks not behaving like the real thing. I could add more mocking although at some point you have to ask what the tests are proving it the components being tested with don't really model the real thing. Seems better to use the real thing and stop playing wack-a-mole with mocks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When extending Rails, instrumentation should be used to wait until the component being extended is fully loaded. Without this, it triggers the loading early through the autoloader which can lead to other problems.
For more background see rails/rails#36546.