C++20 modules support #266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amaanq could you please take a look? |
added 2 commits
May 18, 2024 16:08
cdacamar
reviewed
Jul 18, 2024
| 'export', | ||
| choice($._exportable_item, seq('{', repeat($._exportable_item), '}')) | ||
| ), | ||
| import_declaration: $ => seq( |
There was a problem hiding this comment.
Would it reduce productions to remove the optional('export') and instead add this to the list of exportable items? The standard enforces that a module import declaration shall not be contained in a declaration-seq of an export-declaration: https://eel.is/c%2B%2Bdraft/module#interface-1. This could simplify the productions here since it's more of a semantic error.
added 3 commits
August 1, 2024 22:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #173, this PR implements the C++20 modules grammar after the last contributor time restraints. It Closes #174.
Parser states
before:
after:
Implementation
The most complex rules in the grammar are:
Declarations, in turn, can be any one of those discussed in https://en.cppreference.com/w/cpp/language/declarations. Said that, due to the inerent complexity of c++20 modules, I think that the state count can't go much lower than that. I'm open to suggestions tho.