Merge pull request #10 from trello/dlew/final

Made all component utilities final
trello-archive · Jul 22, 2015 · 985c6f3 · 985c6f3
2 parents 4b94990 + 0a95a70
commit 985c6f3
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 21 deletions.
diff --git a/rxlifecycle-components/src/main/java/com/trello/rxlifecycle/components/RxActivity.java b/rxlifecycle-components/src/main/java/com/trello/rxlifecycle/components/RxActivity.java
@@ -12,17 +12,17 @@ public class RxActivity extends Activity implements ActivityLifecycleProvider {
     private final BehaviorSubject<ActivityEvent> lifecycleSubject = BehaviorSubject.create();
 
     @Override
-    public Observable<ActivityEvent> lifecycle() {
+    public final Observable<ActivityEvent> lifecycle() {
         return lifecycleSubject.asObservable();
     }
 
     @Override
-    public <T> Observable.Transformer<T, T> bindUntilEvent(ActivityEvent event) {
+    public final <T> Observable.Transformer<T, T> bindUntilEvent(ActivityEvent event) {
         return RxLifecycle.bindUntilActivityEvent(lifecycleSubject, event);
     }
 
     @Override
-    public <T> Observable.Transformer<T, T> bindToLifecycle() {
+    public final <T> Observable.Transformer<T, T> bindToLifecycle() {
         return RxLifecycle.bindActivity(lifecycleSubject);
     }
 

diff --git a/rxlifecycle-components/src/main/java/com/trello/rxlifecycle/components/RxDialogFragment.java b/rxlifecycle-components/src/main/java/com/trello/rxlifecycle/components/RxDialogFragment.java
@@ -13,17 +13,17 @@ public class RxDialogFragment extends DialogFragment implements FragmentLifecycl
     private final BehaviorSubject<FragmentEvent> lifecycleSubject = BehaviorSubject.create();
 
     @Override
-    public Observable<FragmentEvent> lifecycle() {
+    public final Observable<FragmentEvent> lifecycle() {
         return lifecycleSubject.asObservable();
     }
 
     @Override
-    public <T> Observable.Transformer<T, T> bindUntilEvent(FragmentEvent event) {
+    public final <T> Observable.Transformer<T, T> bindUntilEvent(FragmentEvent event) {
         return RxLifecycle.bindUntilFragmentEvent(lifecycleSubject, event);
     }
 
     @Override
-    public <T> Observable.Transformer<T, T> bindToLifecycle() {
+    public final <T> Observable.Transformer<T, T> bindToLifecycle() {
         return RxLifecycle.bindFragment(lifecycleSubject);
     }
 

diff --git a/rxlifecycle-components/src/main/java/com/trello/rxlifecycle/components/RxFragment.java b/rxlifecycle-components/src/main/java/com/trello/rxlifecycle/components/RxFragment.java
@@ -13,17 +13,17 @@ public class RxFragment extends Fragment implements FragmentLifecycleProvider {
     private final BehaviorSubject<FragmentEvent> lifecycleSubject = BehaviorSubject.create();
 
     @Override
-    public Observable<FragmentEvent> lifecycle() {
+    public final Observable<FragmentEvent> lifecycle() {
         return lifecycleSubject.asObservable();
     }
 
     @Override
-    public <T> Observable.Transformer<T, T> bindUntilEvent(FragmentEvent event) {
+    public final <T> Observable.Transformer<T, T> bindUntilEvent(FragmentEvent event) {
         return RxLifecycle.bindUntilFragmentEvent(lifecycleSubject, event);
     }
 
     @Override
-    public <T> Observable.Transformer<T, T> bindToLifecycle() {
+    public final <T> Observable.Transformer<T, T> bindToLifecycle() {
         return RxLifecycle.bindFragment(lifecycleSubject);
     }
 

diff --git a/...mponents/src/main/java/com/trello/rxlifecycle/components/support/RxAppCompatActivity.java b/...mponents/src/main/java/com/trello/rxlifecycle/components/support/RxAppCompatActivity.java
@@ -13,17 +13,17 @@ public class RxAppCompatActivity extends AppCompatActivity implements ActivityLi
     private final BehaviorSubject<ActivityEvent> lifecycleSubject = BehaviorSubject.create();
 
     @Override
-    public Observable<ActivityEvent> lifecycle() {
+    public final Observable<ActivityEvent> lifecycle() {
         return lifecycleSubject.asObservable();
     }
 
     @Override
-    public <T> Observable.Transformer<T, T> bindUntilEvent(ActivityEvent event) {
+    public final <T> Observable.Transformer<T, T> bindUntilEvent(ActivityEvent event) {
         return RxLifecycle.bindUntilActivityEvent(lifecycleSubject, event);
     }
 
     @Override
-    public <T> Observable.Transformer<T, T> bindToLifecycle() {
+    public final <T> Observable.Transformer<T, T> bindToLifecycle() {
         return RxLifecycle.bindActivity(lifecycleSubject);
     }
 

diff --git a/...-components/src/main/java/com/trello/rxlifecycle/components/support/RxDialogFragment.java b/...-components/src/main/java/com/trello/rxlifecycle/components/support/RxDialogFragment.java
@@ -14,17 +14,17 @@ public class RxDialogFragment extends DialogFragment implements FragmentLifecycl
     private final BehaviorSubject<FragmentEvent> lifecycleSubject = BehaviorSubject.create();
 
     @Override
-    public Observable<FragmentEvent> lifecycle() {
+    public final Observable<FragmentEvent> lifecycle() {
         return lifecycleSubject.asObservable();
     }
 
     @Override
-    public <T> Observable.Transformer<T, T> bindUntilEvent(FragmentEvent event) {
+    public final <T> Observable.Transformer<T, T> bindUntilEvent(FragmentEvent event) {
         return RxLifecycle.bindUntilFragmentEvent(lifecycleSubject, event);
     }
 
     @Override
-    public <T> Observable.Transformer<T, T> bindToLifecycle() {
+    public final <T> Observable.Transformer<T, T> bindToLifecycle() {
         return RxLifecycle.bindFragment(lifecycleSubject);
     }
 

diff --git a/...ecycle-components/src/main/java/com/trello/rxlifecycle/components/support/RxFragment.java b/...ecycle-components/src/main/java/com/trello/rxlifecycle/components/support/RxFragment.java
@@ -14,17 +14,17 @@ public class RxFragment extends Fragment implements FragmentLifecycleProvider {
     private final BehaviorSubject<FragmentEvent> lifecycleSubject = BehaviorSubject.create();
 
     @Override
-    public Observable<FragmentEvent> lifecycle() {
+    public final Observable<FragmentEvent> lifecycle() {
         return lifecycleSubject.asObservable();
     }
 
     @Override
-    public <T> Observable.Transformer<T, T> bindUntilEvent(FragmentEvent event) {
+    public final <T> Observable.Transformer<T, T> bindUntilEvent(FragmentEvent event) {
         return RxLifecycle.bindUntilFragmentEvent(lifecycleSubject, event);
     }
 
     @Override
-    public <T> Observable.Transformer<T, T> bindToLifecycle() {
+    public final <T> Observable.Transformer<T, T> bindToLifecycle() {
         return RxLifecycle.bindFragment(lifecycleSubject);
     }
 

diff --git a/...omponents/src/main/java/com/trello/rxlifecycle/components/support/RxFragmentActivity.java b/...omponents/src/main/java/com/trello/rxlifecycle/components/support/RxFragmentActivity.java
@@ -13,17 +13,17 @@ public class RxFragmentActivity extends FragmentActivity implements ActivityLife
     private final BehaviorSubject<ActivityEvent> lifecycleSubject = BehaviorSubject.create();
 
     @Override
-    public Observable<ActivityEvent> lifecycle() {
+    public final Observable<ActivityEvent> lifecycle() {
         return lifecycleSubject.asObservable();
     }
 
     @Override
-    public <T> Observable.Transformer<T, T> bindUntilEvent(ActivityEvent event) {
+    public final <T> Observable.Transformer<T, T> bindUntilEvent(ActivityEvent event) {
         return RxLifecycle.bindUntilActivityEvent(lifecycleSubject, event);
     }
 
     @Override
-    public <T> Observable.Transformer<T, T> bindToLifecycle() {
+    public final <T> Observable.Transformer<T, T> bindToLifecycle() {
         return RxLifecycle.bindActivity(lifecycleSubject);
     }