Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv4Address class and IPv6Address class #22

Closed
wants to merge 4 commits into from

Conversation

kazuyas
Copy link
Member

@kazuyas kazuyas commented Mar 27, 2013

I prepare IPv4Address class and IPv6Address class.
Please check and merge this.

#21

@coveralls
Copy link

Coverage increased (+0.0%) when pulling c552869 on kazuyas:ipaddress into f2b4ab7 on trema:master.

View Details

@yasuhito
Copy link
Member

ping @kazuyas 時間のあるときに修正おねがいしまーす。

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 25b8d55 on kazuyas:ipaddress into f2b4ab7 on trema:master.

@kazuyas
Copy link
Member Author

kazuyas commented Aug 9, 2013

修正してみました。mask! に関しては、私としてはなくても大丈夫ですが、オリジナルの IPAddr が持っているのでそのまま残してあります。使う人がいるかもしれないので。

@yasuhito
Copy link
Member

反応が遅くなってすみません。この Pull-Request ですが、あらためて pio https://github.com/trema/pio の方に送ってもらってよいですか?

パケットパーサ/ジェネレータ一式やそれらが使う IPv4Address, IPv6Address, Mac などのクラス一式を Pio に分離しようとしています。

@ghost ghost assigned yasuhito Sep 19, 2013
@yasuhito
Copy link
Member

IPv4Address のほうは修正して Pio にマージしました。
https://github.com/trema/pio/blob/develop/lib/pio/ipv4_address.rb

@yasuhito yasuhito closed this Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants