Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@v2 release fixes #9

Merged
merged 8 commits into from
Nov 11, 2019
Merged

@v2 release fixes #9

merged 8 commits into from
Nov 11, 2019

Conversation

alekseykulikov
Copy link
Member

@alekseykulikov alekseykulikov commented Nov 11, 2019

Goal: simplify docs and project structure to make it easier to get started
Tasks:

  • simplify TS setup, since many deps has been removed
  • fix multiple URLs action
  • docs: use @v2 tag
  • use upload.token and upload.serverBaseUrl
  • docs: improve first example and move env vars to recipes section
  • docs: combine serverBaseUrl and token (possible need a better name) for private server example
  • docs: wrap recipes with details
  • finish docs & check grammar
  • publish release to marketplace https://github.com/treosh/lighthouse-ci-action/releases

Next: #11

@alekseykulikov alekseykulikov changed the title @next release fixes @v2 release fixes Nov 11, 2019
@alekseykulikov alekseykulikov force-pushed the next-fixes branch 2 times, most recently from 2b2869d to beef25b Compare November 11, 2019 11:19
@alekseykulikov alekseykulikov force-pushed the next-fixes branch 2 times, most recently from 4957991 to 0a9c975 Compare November 11, 2019 15:03
@alekseykulikov alekseykulikov merged commit 8460830 into master Nov 11, 2019
@alekseykulikov alekseykulikov deleted the next-fixes branch November 11, 2019 15:12
@alekseykulikov
Copy link
Member Author

@exterkamp I did my best with docs and v2 preparation. Let's use #11 for the next work or new PRs. Github Actions allow moving @v2 tag, so the release is not attached to one commit.

@exterkamp
Copy link
Collaborator

exterkamp commented Nov 11, 2019

@exterkamp I did my best with docs and v2 preparation. Let's use #11 for the next work or new PRs. Github Actions allow moving @v2 tag, so the release is not attached to one commit.

sgtm 😄, looks great!

those <detail> sections are on point 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants