Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backlight refactoring + TPS61062 driver #4552

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

TychoVrahe
Copy link
Contributor

@TychoVrahe TychoVrahe commented Jan 29, 2025

This PR refactors backlight driver and introduces new TPS61062 driver for T3W1.

During refactoring, backlight functionality was separated into its own module, even though we will still use it mostly through display driver.

PVD IRQ was modified to use a bit cleaner access to backlight.

Some bootloader-firmware transitions were fixed to account for the BACKLIGHT_RESET jump behavior on some models.

For D002 devkit, separate PIN backlight driver was introduced, that just switches the backlight on/off. This is done in order to keep the main ltdc-dsi driver cleaner, and it allows better testing while working on D002. It has some negative side effect that fading looks bad on D002, but as its a devkit i don't think we should care much.

The TPS61062 driver uses digital brightness control, and for the generation of pulses TIM+DMA is used.

supersedes #4481

@TychoVrahe TychoVrahe self-assigned this Jan 29, 2025
Copy link

github-actions bot commented Jan 29, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@TychoVrahe TychoVrahe force-pushed the tychovrahe/T3W1/backlight branch from 1c7f675 to d41a72e Compare January 29, 2025 16:28
@TychoVrahe TychoVrahe changed the title backlight refactoring backlight refactoring + TPS61062 driver Jan 30, 2025
@TychoVrahe TychoVrahe requested review from kopecdav and cepetr January 30, 2025 15:48
@TychoVrahe TychoVrahe force-pushed the tychovrahe/T3W1/backlight branch from 8055811 to a913c72 Compare January 30, 2025 15:50
@TychoVrahe TychoVrahe marked this pull request as ready for review January 30, 2025 15:57
@TychoVrahe TychoVrahe requested a review from prusnak as a code owner January 30, 2025 15:57
@TychoVrahe TychoVrahe removed the request for review from prusnak January 30, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 Needs review
Development

Successfully merging this pull request may close these issues.

1 participant