refactor(core): simplify fade_backlight_duration
#4606
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- IIUC, casting to and from `i32` can be removed. - `timer.elapsed()` can be evaluated once per loop iteration. - Removed unused `impl_lerp_for_...` definitions. [no changelog]
|
matejcik
reviewed
Feb 11, 2025
core/embed/rust/src/ui/lerp.rs
Outdated
| impl_lerp_for_unsigned!(u8); | ||
| impl_lerp_for_unsigned!(u16); | ||
| impl_lerp_for_unsigned!(u32); | ||
|
|
||
| impl_lerp_for_signed!(f32); |
There was a problem hiding this comment.
any specific reason to remove those? they won't be compiled in when unused, and it seems generally useful to have them available for all types
There was a problem hiding this comment.
You're right - I will revert this change.
There was a problem hiding this comment.
Reverted in fb6b11b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i32can be removed.timer.elapsed()can be evaluated once per loop iteration.