-
-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure hardware CI timeouts to collect pytest logs #4609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For pytest-dev/pytest-timeout#165. [no changelog]
Otherwise, failed tests' logs are not shown. [no changelog]
|
Tested the new diff --git a/tests/device_tests/binance/test_get_address.py b/tests/device_tests/binance/test_get_address.py
index cdb6e7227..33c5fe7eb 100644
--- a/tests/device_tests/binance/test_get_address.py
+++ b/tests/device_tests/binance/test_get_address.py
@@ -43,6 +43,7 @@ def test_binance_get_address(client: Client, path: str, expected_address: str):
address = get_address(client, parse_path(path), show_display=True)
assert address == expected_address
+ raise AssertionError("TEST ERROR")
@pytest.mark.parametrize("path, expected_address", BINANCE_ADDRESS_TEST_VECTORS) The test run is cancelled and the failure log is collected correctly.
|
mmilata
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci
Continuous Integration (CI) related
core
Trezor Core firmware. Runs on Trezor Model T and T2B1.
hardware only
Issue which does not appear on the emulator - but on physical device only.
python
Pull requests that update Python code
tests
Automated integration tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are no logs from failed tests in case of a timeout:
https://github.com/trezor/trezor-firmware/actions/runs/13252434089/job/36993028885
For example, in the above run, all tests seem to timeout (after 20m) after the first test failure (at
04:31:28
), causing the job to timeout (at08:11:22
) - and there are no pytest failure logs :(