Refactor QrScannerModal, remove unused allowPaste prop
#14513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvaclavik
approved these changes
Sep 24, 2024
Comment on lines
-58
to
-62
| // eslint-disable-next-line local-rules/no-override-ds-component | ||
| const ErrorTitle = styled(Paragraph)` | ||
| text-align: center; | ||
| color: ${colors.legacy.TYPE_RED}; | ||
| `; |
| <Translation id="TR_GENERIC_ERROR_TITLE" /> | ||
| </ErrorTitle> | ||
| </Paragraph> | ||
| <ErrorMessage>{error}</ErrorMessage> |
There was a problem hiding this comment.
Not 100% sure but I think it could be possible to replace also this one:
<Paragraph variant="destructive" align="center" margin={{ spacings.xxxl }}>...</Paragrap>
Why I'm not sure: Because there is a span but at the same time i think shouldn't be there because we use align.
|
Okay I rewrote the whole thing. Now, if you can do me a favour... #14512 Before: After: |
| @@ -84,43 +30,17 @@ const StyledQrReader = styled(QrReader)` | |||
| padding-top: initial !important; | |||
|
|
|||
| & > video { | |||
| border-radius: 16px; | |||
| border-radius: ${spacingsPx.md}; | |||
There was a problem hiding this comment.
Use border radii variables from theme package?
seibei-iguchi
approved these changes
Sep 25, 2024
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/11029931486 |
trezor-ci
force-pushed
the
fix/release-camera
branch
from
d626538 to
b741a40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring I made as a preparation for #13460. The
allowPasteprop was not used. Removing some legacy styling.QA: Just refactoring and design update (see pictures below).