feat: introduce internal_model UNKNOWN, add support for it in the Suite #15589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
mroz22
force-pushed
the
unkwnon-internal-model
branch
3 times, most recently
from
bcc39a3 to
f47b629
Compare
mroz22
requested review from
szymonlesisz,
martykan and
marekrjpolak
as code owners
mroz22
force-pushed
the
unkwnon-internal-model
branch
2 times, most recently
from
f26cd00 to
d964041
Compare
peter-sanderson
force-pushed
the
unkwnon-internal-model
branch
from
d964041 to
bfd4c4a
Compare
peter-sanderson
requested review from
komret,
jvaclavik and
seibei-iguchi
as code owners
peter-sanderson
changed the title
peter-sanderson
force-pushed
the
unkwnon-internal-model
branch
2 times, most recently
from
ac3d176 to
0156ea3
Compare
peter-sanderson
force-pushed
the
unkwnon-internal-model
branch
from
0156ea3 to
d3aec49
Compare
peter-sanderson
approved these changes
Dec 9, 2024
peter-sanderson
force-pushed
the
unkwnon-internal-model
branch
from
d3aec49 to
2710a33
Compare
packages/suite-data/files/images/svg/device-confirm-trezor-t2t1.svg
Outdated
Show resolved
Hide resolved
packages/suite-data/files/images/svg/device_confirm_trezor_unknown.svg
Outdated
Show resolved
Hide resolved
mroz22
force-pushed
the
unkwnon-internal-model
branch
from
2710a33 to
7488355
Compare
peter-sanderson
force-pushed
the
unkwnon-internal-model
branch
3 times, most recently
from
3c2e003 to
f8fa327
Compare
peter-sanderson
force-pushed
the
unkwnon-internal-model
branch
from
f8fa327 to
f0835f8
Compare
Lemonexe
approved these changes
Dec 10, 2024
packages/suite/src/views/wallet/staking/components/DeviceButton.tsx
Outdated
Show resolved
Hide resolved
| [DeviceModelInternal.UNKNOWN]: 'trezorModelOneFilled', // Just to provide something that wont break UI | ||
| }; | ||
|
|
||
| export const mapTrezorModelToIcon: Record<DeviceModelInternal, IconName> = { |
There was a problem hiding this comment.
💭 maybe there could be notice that these are deprecated. Otherwise you have to click through IconName to find out. Perhaps rename to mapTrezorModelToDeprecatedIcon
There was a problem hiding this comment.
Good idea, done. thanks 🙇
peter-sanderson
force-pushed
the
unkwnon-internal-model
branch
3 times, most recently
from
9852e49 to
a0d9e8b
Compare
|
|
||
| feat.model = 'T'; | ||
| // @ts-expect-error | ||
| feat.internal_model = 'brambora'; |
peter-sanderson
force-pushed
the
unkwnon-internal-model
branch
from
a0d9e8b to
ff51bd3
Compare
PeKne
approved these changes
Dec 11, 2024
jvaclavik
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original description:
cc @peter-sanderson
when I hardcode-rewrite incoming features.internal_model to some bogus