Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(connect): default to nversion=1 again #15614

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Conversation

marekrjpolak
Copy link
Contributor

@marekrjpolak marekrjpolak commented Nov 27, 2024

Description

Reverts defaulting to nVersion=2 in Connect back to nVersion=1. It's a breaking change, so let's better leave it for Connect 10.

Instead, explicitly set nVersion=2 from Suite so #15373 has some effect at least there.

Copy link

github-actions bot commented Nov 27, 2024

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 12
  • More info

Learn more about 𝝠 Expo Github Action

@marekrjpolak marekrjpolak marked this pull request as ready for review November 28, 2024 10:41
@mroz22 mroz22 merged commit 05af037 into develop Nov 28, 2024
146 of 160 checks passed
@mroz22 mroz22 deleted the chore/revert-nversion branch November 28, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants