Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup the assert logic #19

Merged
merged 4 commits into from
Nov 8, 2024
Merged

cleanup the assert logic #19

merged 4 commits into from
Nov 8, 2024

Conversation

folkertdev
Copy link
Collaborator

I think it's important to keep using the exit code 3 for errors (it's documented behavior here https://sourceware.org/bzip2/manual/manual.html#critical-error).

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
c2rust-lib.rs 98.21% 1 Missing ⚠️
Files with missing lines Coverage Δ
bzlib.rs 87.66% <ø> (+2.53%) ⬆️
c2rust-lib.rs 98.21% <98.21%> (ø)

@folkertdev folkertdev force-pushed the main branch 4 times, most recently from c8a6e27 to 2820025 Compare November 8, 2024 10:25
c2rust-lib.rs Outdated Show resolved Hide resolved
c2rust-lib.rs Outdated Show resolved Hide resolved
@folkertdev folkertdev merged commit 3a37d9c into main Nov 8, 2024
11 checks passed
@folkertdev folkertdev deleted the cleanup-asserts branch November 8, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants