Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup bzip2recover.rs #22

Merged
merged 39 commits into from
Nov 7, 2024
Merged

cleanup bzip2recover.rs #22

merged 39 commits into from
Nov 7, 2024

Conversation

folkertdev
Copy link
Collaborator

best reviewed commit-by-commit I think; they are small and atomic

@folkertdev
reinstate use of __errno_location
c5c9ce3
@folkertdev
bzip2recover.rs: use std::process::exit
f60b628
@folkertdev
bzip2recover.rs: remove usage of fprintf
2750dc4
@folkertdev
bzip2recover.rs: remove usage of malloc and free
076bfa2
@folkertdev
bzip2recover.rs: don't leak the Box
0f5edf4
@folkertdev
bzip2recover.rs: cleanup after using Box everywhere
923583e
@folkertdev
bzip2recover.rs: just get rid of the boxing altogether
bf7d9ba
@folkertdev
bzip2recover.rs: cleanup argv/argc handling
0856f61
@folkertdev
bzip2recover.rs: pull out the handing of invalid input
d55f0b4
@folkertdev
bzip2recover.rs: perform cstr stuff inside of main_0
e313507
@folkertdev
bzip2recover.rs: use in_filename_cstr instead of the static
2958320
@folkertdev
bzip2recover.rs: improve formatting of the output file names
26ca30c
@folkertdev
bzip2recover.rs: start using rust std::file::File
025ba53
@folkertdev
bzip2recover.rs: use rust std::file::File for writing too
6c849eb
@folkertdev
bzip2recover.rs: cleanup comments
799cf14
@folkertdev
bzip2recover.rs: use rust std::io::Write and std::io::Read
6061f31
@folkertdev
bzip2recover.rs: start emitting errors again
ffb4553
@folkertdev
bzip2recover.rs: start emitting all errors again
a95f572
@folkertdev
bzip2recover.rs: return ExitCode instead of std::process::exit
fb7a4eb
@folkertdev
bzip2recover.rs: cleanup imports
d3edd42
@folkertdev
bzip2recover.rs: refactor tooManyBlocks
0023f48
@folkertdev
bzip2recover.rs: mark some functions as safe
ce71020
@folkertdev
bzip2recover.rs: remove IN_FILENAME
c5eed4d
@folkertdev
bzip2recover.rs: remove PROGNAME
51f2863
@folkertdev
bzip2recover.rs: MaybeUInt64 -> u64
2b129e7
@folkertdev
bzip2recover.rs: use an atomic to keep track of bytes out
d077a66
@folkertdev
bzip2recover.rs: get rid of final unsafe
fae4ba7
@folkertdev
bzip2recover.rs: remove CString usage
a452565
@folkertdev
bzip2recover.rs: cleanup
d98327c
@folkertdev
bzip2recover.rs: cleanup casts
f6482b0
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

bjorn3
bjorn3 reviewed Nov 7, 2024
View reviewed changes
bzip2recover.rs Outdated Show resolved Hide resolved
bjorn3
bjorn3 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@bjorn3 bjorn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the stack overflow in case of small stacks fixed.

@folkertdev folkertdev merged commit 92fc9a7 into main Nov 7, 2024
10 checks passed
@folkertdev folkertdev deleted the bzip2recover-initial branch November 7, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@folkertdev @bjorn3