Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fn uncompress: cleanup #29

Merged
merged 28 commits into from
Nov 11, 2024
Merged

fn uncompress: cleanup #29

merged 28 commits into from
Nov 11, 2024

Conversation

folkertdev
Copy link
Collaborator

No description provided.

@folkertdev
fn uncompressStream: fix missing state transition
8058718
@folkertdev
fn basic_invalid_file: make this test work on all platforms
80f3dcb
@folkertdev
bzip2.rs: test for using the -c and -t flags together
51d0a74
@folkertdev
bzip2.rs: cleanup casts
8d827a0
@folkertdev
bzip2.rs: make cantGuess a bool
e7b4dad
@folkertdev
bzip2.rs: add test for F2F (file to file) mode
9df2ea7
@folkertdev
fn uncompress: clean up state machine logic with labeled block
3d7c828
@folkertdev
fn uncompress: accept a string
ed04ba1
@folkertdev
fn uncompress: test some file extension logic
f917b51
@folkertdev
fn uncompress: simplify extension logic
3f65d1a
@folkertdev
fn uncompress: don't rely on cstring for in_name
d22c67b
@folkertdev
fn uncompress: use in_name and out_name in more error messages
e88b5be
@folkertdev
fn uncompress: cleanup casts
6e71575
@folkertdev
fn uncompress: logic for counting hardlinks on linux
7d0e72b
@folkertdev
fn uncompress: cleanup fprintf
eaa2aba
@folkertdev
fn uncompress: cleanup more fprintf
d10e4d8
@codecov Codecov
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

@folkertdev folkertdev requested a review from bjorn3 November 11, 2024 12:16
bjorn3
bjorn3 reviewed Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@bjorn3 bjorn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "fn uncompress: make magicNumberOK a bool" commit should be dropped as it is empty.

bzip2.rs Outdated Show resolved Hide resolved
@folkertdev folkertdev force-pushed the cleanup-uncompress branch 2 times, most recently from f96c6d0 to ca7080f Compare November 11, 2024 13:22
@folkertdev
Copy link
Collaborator Author

the empty commit has been removed, and I cleaned up the signal handlers a bit too.

@folkertdev folkertdev requested a review from bjorn3 November 11, 2024 13:26
@folkertdev folkertdev merged commit 706ca26 into main Nov 11, 2024
11 checks passed
@folkertdev folkertdev deleted the cleanup-uncompress branch November 11, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@folkertdev @bjorn3