Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanups #35

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Various cleanups #35

merged 3 commits into from
Nov 12, 2024

Conversation

bjorn3
Copy link
Collaborator

@bjorn3 bjorn3 commented Nov 12, 2024

  • Follow Rust naming conventions for function names
  • Reduce visibility of items where possible
  • Remove #[repr] where possible and remove a couple of unused fields exposed by this.

@bjorn3 bjorn3 requested a review from folkertdev November 12, 2024 10:31
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
blocksort.rs 97.52% <100.00%> (ø)
bzip2.rs 82.68% <ø> (ø)
bzip2recover.rs 97.83% <100.00%> (ø)
bzlib.rs 88.35% <100.00%> (ø)
c2rust-lib.rs 98.21% <ø> (ø)
compress.rs 99.63% <100.00%> (ø)
decompress.rs 94.13% <100.00%> (ø)
huffman.rs 96.87% <100.00%> (ø)

@bjorn3 bjorn3 merged commit 0818715 into main Nov 12, 2024
11 checks passed
@bjorn3 bjorn3 deleted the visibility_cleanup branch November 12, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants