Improve safety of the C interface implementation #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
bjorn3
commented
Nov 12, 2024
| } | ||
|
|
||
| if !s.is_null() { |
There was a problem hiding this comment.
We are already dereferencing this pointer before this point anyway, so s has to be a non-NULL pointer to not have UB. And if allocation failed, we should return BZ_MEM_ERROR before this. No need to check for NULL again.
bjorn3
commented
Nov 12, 2024
| } | ||
| s.arr1.dealloc(bzfree, strm.opaque); | ||
| s.arr2.dealloc(bzfree, strm.opaque); | ||
| s.ftab.dealloc(bzfree, strm.opaque); |
There was a problem hiding this comment.
dealloc checks if the value exists before deallocating.
This avoid self-referential types
folkertdev
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.