add configuration to build a dynamic library #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still needs some CI checks I think (for e.g. bzpipe working) |
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
bjorn3
reviewed
Dec 2, 2024
libbzip2-rs-sys-cdylib/Cargo.toml
Outdated
| rust-version = "1.82" # MSRV | ||
|
|
||
| [lib] | ||
| name = "bz2_rs" # turns into e.g. `libz_rs.so` |
bjorn3
reviewed
Dec 2, 2024
bjorn3
reviewed
Dec 2, 2024
bjorn3
reviewed
Dec 2, 2024
bjorn3
reviewed
Dec 2, 2024
bjorn3
reviewed
Dec 2, 2024
folkertdev
commented
Dec 2, 2024
Co-authored-by: bjorn3 <[email protected]>
folkertdev
force-pushed
the
build-dynamic-library
branch
3 times, most recently
from
8537a4f to
f34e208
Compare
folkertdev
force-pushed
the
build-dynamic-library
branch
from
f34e208 to
02573a9
Compare
bjorn3
reviewed
Dec 2, 2024
folkertdev
commented
Dec 2, 2024
.github/workflows/checks.yaml
Outdated
Comment on lines
433
to
441
| # - name: "cdylib: no_std" | ||
| # env: | ||
| # LD_LIBRARY_PATH: "target/${{matrix.target}}/release/deps" | ||
| # working-directory: libbzip2-rs-sys-cdylib | ||
| # run: | | ||
| # cargo build --release --target ${{matrix.target}} --no-default-features | ||
| # cc -o bzpipe_no_std bzpipe_no_std.c target/${{matrix.target}}/release/deps/libbz2_rs.so -I ../ | ||
| # ./bzpipe_no_std < Cargo.toml | ./bzpipe_no_std -d > out.txt | ||
| # cmp -s Cargo.toml out.txt |
There was a problem hiding this comment.
I'm still not sure how this works for zlib-rs and doesn't here
There was a problem hiding this comment.
got it, the [lib] section of the main crate needs to be removed; that's allright, it is only meant to be used as a crate anyway, building libraries should happen with the cdylib crate.
bjorn3
reviewed
Dec 2, 2024
bjorn3
reviewed
Dec 2, 2024
bjorn3
reviewed
Dec 2, 2024
bjorn3
approved these changes
Dec 2, 2024
Co-authored-by: bjorn3 <[email protected]>
folkertdev
force-pushed
the
build-dynamic-library
branch
3 times, most recently
from
95fad82 to
9a01ee7
Compare
folkertdev
force-pushed
the
build-dynamic-library
branch
from
9a01ee7 to
28f5427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.