Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the rust allocator when std is not used #67

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

bjorn3
Copy link
Collaborator

@bjorn3 bjorn3 commented Dec 11, 2024

No description provided.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
libbz2-rs-sys/src/allocator.rs 62.35% <100.00%> (ø)

@bjorn3 bjorn3 requested a review from folkertdev December 11, 2024 12:24
Copy link
Collaborator

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a convenient way to test that rust-allocator can be used without std?

@bjorn3
Copy link
Collaborator Author

bjorn3 commented Dec 11, 2024

I used cargo build -p libbz2-rs-sys --no-default-features --features rust-allocator locally. I can add a CI check for that.

@folkertdev
Copy link
Collaborator

yes I think that's a good idea

@bjorn3 bjorn3 merged commit 7323651 into main Dec 11, 2024
20 checks passed
@bjorn3 bjorn3 deleted the rust_allocator_no_std branch December 11, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants