Use panics in handle_assert_failure too when stdio mode is disabled #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using libbz2-rs-sys as a rust dependency, it is not possible to define bz_internal_error in a way that GNU ld will accept. The definition would come before the use in libbz2-rs-sys and GNU ld will only resolve symbol uses when the defining static library comes after the static library that needs the symbol. When using as cdylib bz_internal_error will still be called by the panic handler in libbz2-rs-sys-cdylib.
Codecov ReportAttention: Patch coverage is
|
folkertdev
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using libbz2-rs-sys as a rust dependency, it is not possible to define bz_internal_error in a way that GNU ld will accept. The definition would come before the use in libbz2-rs-sys and GNU ld will only resolve symbol uses when the defining static library comes after the static library that needs the symbol.
When using as cdylib bz_internal_error will still be called by the panic handler in libbz2-rs-sys-cdylib.