Remove double bounds check #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
folkertdev
commented
Jan 14, 2025
Comment on lines
+767
to
+771
| let index = zvec - s.base[gBase as usize][zn as usize]; | ||
| nextSym = match s.perm[gPerm as usize].get(index as usize) { | ||
| Some(&nextSym) => nextSym, | ||
| None => error!(BZ_DATA_ERROR), | ||
| }; |
There was a problem hiding this comment.
the s.perm[i] arrays are 258 elements long, so the check for the index value to be in bounds was happening twice (though of course llvm might optimize that out)
Comment on lines
+358
to
+362
| match uc { | ||
| 0x17 => current_block = BZ_X_ENDHDR_2, | ||
| 0x31 => current_block = BZ_X_BLKHDR_2, | ||
| _ => error!(BZ_DATA_ERROR), | ||
| }; |
There was a problem hiding this comment.
this is just a cleanup that i spotted
Comment on lines
-1288
to
-1289
| groupNo = -1; | ||
| groupPos = 0; |
There was a problem hiding this comment.
moved over to hopefully make it clearer why groupNo cannot be unsigned (currently anyway, maybe with some extra refactoring).
bjorn3
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.