-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix high CPU usage #845
Fix high CPU usage #845
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #845 +/- ##
==========================================
+ Coverage 57.48% 57.96% +0.47%
==========================================
Files 75 75
Lines 10421 10140 -281
==========================================
- Hits 5991 5878 -113
+ Misses 4430 4262 -168 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvdrz Your changes look good to me (if they pass the test suite)! (I can't formally review this PR since I opened it.)
Also again thanks for @AppleSheeple for debugging this issue and proposing the original fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing a formal approve
NOTE: #843 should be merged before this one (and then this one rebased on the new main) to fix the clippy issues.