cdylib cleanup #256
Merged
cdylib cleanup #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
folkertdev
force-pushed
the
cdylib-cleanup
branch
from
a720f9e to
1556e3b
Compare
bjorn3
reviewed
Dec 3, 2024
bjorn3
reviewed
Dec 3, 2024
bjorn3
reviewed
Dec 3, 2024
bjorn3
reviewed
Dec 3, 2024
| #else | ||
| strm.zalloc = NULL; | ||
| strm.zfree = NULL; | ||
| #endif |
There was a problem hiding this comment.
Unconditionally using custom_zalloc/custom_zfree would be fine too, right?
There was a problem hiding this comment.
it would work, but we use this test for running the various allocators in CI
Co-authored-by: bjorn3 <[email protected]>
folkertdev
force-pushed
the
cdylib-cleanup
branch
from
fdaee95 to
590db29
Compare
bjorn3
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.