Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code quality checks #51

Merged
merged 9 commits into from
Mar 1, 2024
Merged

Add code quality checks #51

merged 9 commits into from
Mar 1, 2024

Conversation

spalmer25
Copy link
Collaborator

@spalmer25 spalmer25 commented Feb 27, 2024 •
edited
Loading

include #9

  • add pre-commit
  • check pre-commit in CI
  • update clang format
  • check c with cppcheck in CI
  • add MISRA rules in cppcheck

Following issue: Fix MISRA checks

@spalmer25 spalmer25 self-assigned this Feb 27, 2024
@spalmer25 spalmer25 force-pushed the palmer@functori@add-codeql-check branch 29 times, most recently from a370f09 to 9f4add3 Compare February 28, 2024 12:39
@spalmer25 spalmer25 force-pushed the palmer@functori@add-codeql-check branch 2 times, most recently from 701e9c2 to 3e92d3b Compare March 1, 2024 11:00
@spalmer25 spalmer25 marked this pull request as ready for review March 1, 2024 12:27
ajinkyaraj-23
ajinkyaraj-23 reviewed Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase on main is required.
Also test a case where pre-commit run --all-files fails locally and check if it fails on CI too.

@spalmer25 spalmer25 force-pushed the palmer@functori@add-codeql-check branch from 3e92d3b to 642c85a Compare March 1, 2024 12:41
@ajinkyaraj-23 ajinkyaraj-23 mentioned this pull request Mar 1, 2024
Closed
3 tasks
spalmer25 added 8 commits March 1, 2024 13:47
@spalmer25
Pre-commit: add a pre-commit config
6887a54 
 - check that pre-commit style is respected in CI
@spalmer25
Pre-commit: add a trailing-whitespace hook
81a543b
@spalmer25
Pre-commit: add end-of-file-fixer hook
079c77f
@spalmer25
Pre-commit: add check-yaml hook
e383bd7
@spalmer25
Pre-commit: add check-added-large-files hook
164528a
@spalmer25
Clang: bump clang-format version to 17
f9976ea
@spalmer25
Clang: enforce block with braces
0385098
@spalmer25
Cppcheck: add cppcheck in CI
1f8fb6a 
 - fix an error: Found a exit path from function with non-void return
     type that has missing return statement [missingReturn]
 - fix an error: Syntax Error: AST broken, 'for' doesn't have two
     operands. [internalAstError]
@spalmer25 spalmer25 force-pushed the palmer@functori@add-codeql-check branch from 642c85a to e739186 Compare March 1, 2024 12:47
@spalmer25
Copy link
Collaborator Author

Rebase on main is required. Also test a case where pre-commit run --all-files fails locally and check if it fails on CI too.

Changement: 88ad362
Error: https://github.com/trilitech/ledger-app-tezos-baking/actions/runs/8111632321/job/22171245883?pr=51

@spalmer25 spalmer25 force-pushed the palmer@functori@add-codeql-check branch from 88ad362 to e739186 Compare March 1, 2024 12:53
@spalmer25 spalmer25 requested a review from ajinkyaraj-23 March 1, 2024 12:53
@spalmer25 spalmer25 force-pushed the palmer@functori@add-codeql-check branch from e739186 to 963f3b9 Compare March 1, 2024 13:17
ajinkyaraj-23
ajinkyaraj-23 reviewed Mar 1, 2024
View reviewed changes
test/apdu-tests/apdu.sh Show resolved Hide resolved
test/README.md Show resolved Hide resolved
@ajinkyaraj-23 ajinkyaraj-23 self-requested a review March 1, 2024 14:29
ajinkyaraj-23
ajinkyaraj-23 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalmer25 spalmer25 mentioned this pull request Mar 1, 2024
Closed
@spalmer25 spalmer25 merged commit c4b3c35 into main Mar 1, 2024
28 checks passed
@ajinkyaraj-23 ajinkyaraj-23 mentioned this pull request Mar 1, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ajinkyaraj-23 ajinkyaraj-23 ajinkyaraj-23 approved these changes

@emturner emturner Awaiting requested review from emturner

Assignees

@spalmer25 spalmer25

Labels
new-baking-app
Projects
None yet
Milestone
Baking app upgrade
Development

Successfully merging this pull request may close these issues.
2 participants
@spalmer25 @ajinkyaraj-23