Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tiles for these two tutorials #518

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Add tiles for these two tutorials #518

merged 2 commits into from
Jan 22, 2025

Conversation

timothymcmackin
Copy link
Collaborator

@timothymcmackin timothymcmackin commented Jan 17, 2025

Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-staging ✅ Ready (Inspect) Visit Preview Jan 22, 2025 6:01pm

@NicNomadic
Copy link
Collaborator

Is there any way I can leave a comment on the tile named "Join the DAL as a baker in 5 steps"?

@NicNomadic
Copy link
Collaborator

Is there any way I can create a discussion thread not related to any line of the changed files? I mean, a thread where discussions can go on inside until we mark it as Solved. As we do for discussion of some changed line.

@NicNomadic
Copy link
Collaborator

NB I'm using this PR as a case study to challenge the limitations of Github WRT Gitlab. Don't take it personally 😄

@timothymcmackin
Copy link
Collaborator Author

Is there any way I can leave a comment on the tile named "Join the DAL as a baker in 5 steps"?

Not directly. AFAIK Github only lets you comment on changed lines and nearby lines. https://github.com/orgs/community/discussions/9099

@NicNomadic
Copy link
Collaborator

Is there any way I can leave a comment on the tile named "Join the DAL as a baker in 5 steps"?

Not directly. AFAIK Github only lets you comment on changed lines and nearby lines. https://github.com/orgs/community/discussions/9099

Yeah, that's a pity. Thanks for confirming that.

@NicNomadic
Copy link
Collaborator

Is there any way I can leave a comment on the tile named "Join the DAL as a baker in 5 steps"?

Not directly. AFAIK Github only lets you comment on changed lines and nearby lines. https://github.com/orgs/community/discussions/9099

Yeah, that's a pity. Thanks for confirming that.

[Solve the thread] 🙂

@NicNomadic
Copy link
Collaborator

LGTM, my only comment is that the tile for the run-dal-node tutorial should be changed according to the new title of the tutorial (run an Octez node), eventually also mentioning the DAL, but not necessarily.

emoji="🍞"
href="/tutorials/join-dal-baker"
description="Learn how to participate in the Data Availability Layer, which is a peer-to-peer network for sharing data across Tezos"
description="See a complete walkthrough of setting up a baking operation including a Tezos node, DAL node, and baker"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a baking operation" sounds confusing to me. Maybe "a full-fledged Tezos node" or just "Tezos node"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to "See a complete walkthrough of becoming a baker by setting up a Tezos node, DAL node, and baker."

Copy link
Collaborator

@NicNomadic NicNomadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo slight twist in a tile name

@timothymcmackin timothymcmackin merged commit 89814ce into main Jan 22, 2025
4 checks passed
@timothymcmackin timothymcmackin deleted the tutorial-tiles branch January 22, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants