-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tiles for these two tutorials #518
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Is there any way I can leave a comment on the tile named "Join the DAL as a baker in 5 steps"? |
Is there any way I can create a discussion thread not related to any line of the changed files? I mean, a thread where discussions can go on inside until we mark it as Solved. As we do for discussion of some changed line. |
NB I'm using this PR as a case study to challenge the limitations of Github WRT Gitlab. Don't take it personally 😄 |
Not directly. AFAIK Github only lets you comment on changed lines and nearby lines. https://github.com/orgs/community/discussions/9099 |
Yeah, that's a pity. Thanks for confirming that. |
[Solve the thread] 🙂 |
LGTM, my only comment is that the tile for the run-dal-node tutorial should be changed according to the new title of the tutorial (run an Octez node), eventually also mentioning the DAL, but not necessarily. |
da82ba9
to
f42cda3
Compare
docs/tutorials.mdx
Outdated
emoji="🍞" | ||
href="/tutorials/join-dal-baker" | ||
description="Learn how to participate in the Data Availability Layer, which is a peer-to-peer network for sharing data across Tezos" | ||
description="See a complete walkthrough of setting up a baking operation including a Tezos node, DAL node, and baker" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"a baking operation" sounds confusing to me. Maybe "a full-fledged Tezos node" or just "Tezos node"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to "See a complete walkthrough of becoming a baker by setting up a Tezos node, DAL node, and baker."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo slight twist in a tile name
Two intermediate tutorials have no tiles on https://docs.tezos.com/tutorials. This PR adds them.
Preview: https://docs-staging-git-tutorial-tiles-trili-tech.vercel.app/tutorials#intermediate