-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set dependency versions #521
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
timothymcmackin
changed the title
[wip] Set dependncy versions
[wip] Set dependency versions
Jan 20, 2025
timothymcmackin
force-pushed
the
set-dependencies
branch
from
January 21, 2025 18:59
23e0ab4
to
c3ca96d
Compare
timothymcmackin
force-pushed
the
set-dependencies
branch
from
January 21, 2025 20:53
c3ca96d
to
3ad58c6
Compare
timothymcmackin
changed the title
[wip] Set dependency versions
Set dependency versions
Jan 22, 2025
NicNomadic
reviewed
Jan 23, 2025
NicNomadic
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo a followup to ignore minor version numbers for Octez (and perhaps tje last number in all the other dependencies).
timothymcmackin
force-pushed
the
set-dependencies
branch
2 times, most recently
from
January 28, 2025 14:13
304dbbe
to
c164063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#503 introduced a test for dependency versions. This PR adds the metadata on the latest versions of dependencies that procedures were tested with.
I've got some TODOs in place for two tutorials that I couldn't test right away; they are set to version number zero so the check will show them as outdated. I'd like to merge this as it is to avoid too many conflicts down the road.
This work has spawned some updates in the typos PR and in these: