Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dependency versions #521

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Set dependency versions #521

merged 5 commits into from
Jan 28, 2025

Conversation

timothymcmackin
Copy link
Collaborator

@timothymcmackin timothymcmackin commented Jan 17, 2025

#503 introduced a test for dependency versions. This PR adds the metadata on the latest versions of dependencies that procedures were tested with.

I've got some TODOs in place for two tutorials that I couldn't test right away; they are set to version number zero so the check will show them as outdated. I'd like to merge this as it is to avoid too many conflicts down the road.

This work has spawned some updates in the typos PR and in these:

@timothymcmackin timothymcmackin self-assigned this Jan 17, 2025
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-staging ✅ Ready (Inspect) Visit Preview Jan 28, 2025 2:16pm

@timothymcmackin timothymcmackin changed the title [wip] Set dependncy versions [wip] Set dependency versions Jan 20, 2025
@timothymcmackin timothymcmackin marked this pull request as ready for review January 22, 2025 16:07
@timothymcmackin timothymcmackin changed the title [wip] Set dependency versions Set dependency versions Jan 22, 2025
docs/dApps/wallets.md Show resolved Hide resolved
src/scripts/dependencies.json Show resolved Hide resolved
Copy link
Collaborator

@NicNomadic NicNomadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a followup to ignore minor version numbers for Octez (and perhaps tje last number in all the other dependencies).

@timothymcmackin timothymcmackin force-pushed the set-dependencies branch 2 times, most recently from 304dbbe to c164063 Compare January 28, 2025 14:13
@timothymcmackin timothymcmackin merged commit 16c6298 into main Jan 28, 2025
4 checks passed
@timothymcmackin timothymcmackin deleted the set-dependencies branch January 28, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants