-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web][UMA-1130] Remove unnecessary data from localstorage #2194
Merged
ajinkyaraj-23
merged 1 commit into
main
from
ajinkyaraj-23@2162-encrypt-the-beacon-localstorage
Feb 13, 2025
Merged
[Web][UMA-1130] Remove unnecessary data from localstorage #2194
ajinkyaraj-23
merged 1 commit into
main
from
ajinkyaraj-23@2162-encrypt-the-beacon-localstorage
Feb 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dec7b39
to
dcb2a1b
Compare
dcb2a1b
to
230983c
Compare
230983c
to
a47155f
Compare
68fc84b
to
5c297e1
Compare
OKendigelyan
requested changes
Feb 12, 2025
ajinkyaraj-23
commented
Feb 12, 2025
54d2e82
to
151c54a
Compare
OKendigelyan
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
151c54a
to
c652cd6
Compare
…saving them to localstorage. assets, annoucements, tokens , protocol settings These items need not be saved in localstorage. Errors can be sent to backend sentry. Update migration after removing the blacklisted keys.
05a58cd
to
68b7e1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In order to optimize local storage encryption , reduce the localstorage size by removing the data which need not be in localstorage, for example, announcements, assets, protocol settings. which we are getting from rpc/tzkt anyways.
Issue: UMA-1130