Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web][UMA-1130] Remove unnecessary data from localstorage #2194

Merged

Conversation

ajinkyaraj-23
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 commented Dec 3, 2024

Proposed changes

In order to optimize local storage encryption , reduce the localstorage size by removing the data which need not be in localstorage, for example, announcements, assets, protocol settings. which we are getting from rpc/tzkt anyways.
Issue: UMA-1130

@ajinkyaraj-23 ajinkyaraj-23 linked an issue Dec 3, 2024 that may be closed by this pull request
Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-embed-iframe 🛑 Canceled (Inspect) Feb 13, 2025 0:51am
umami-embed-iframe-ghostnet 🛑 Canceled (Inspect) Feb 13, 2025 0:51am
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 0:51am
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 0:51am

@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@2162-encrypt-the-beacon-localstorage branch from dec7b39 to dcb2a1b Compare January 30, 2025 10:50
@ajinkyaraj-23 ajinkyaraj-23 changed the title Create encrypted storage for beacon Create encrypted storage to hide PII and sensitive data Jan 30, 2025
@ajinkyaraj-23 ajinkyaraj-23 self-assigned this Jan 30, 2025
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@2162-encrypt-the-beacon-localstorage branch from dcb2a1b to 230983c Compare January 30, 2025 15:45
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@2162-encrypt-the-beacon-localstorage branch from 230983c to a47155f Compare February 11, 2025 13:28
@ajinkyaraj-23 ajinkyaraj-23 changed the title Create encrypted storage to hide PII and sensitive data remove unnecessary data from localstorage Feb 12, 2025
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@2162-encrypt-the-beacon-localstorage branch 2 times, most recently from 68fc84b to 5c297e1 Compare February 12, 2025 14:37
packages/state/src/reducer.ts Outdated Show resolved Hide resolved
packages/state/src/migrations.test.ts Outdated Show resolved Hide resolved
packages/state/src/migrations.ts Outdated Show resolved Hide resolved
packages/state/src/reducer.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@OKendigelyan OKendigelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…saving them to localstorage.

assets, annoucements, tokens , protocol settings
These items need not be saved in localstorage. Errors can be sent to backend sentry.

Update migration after removing the blacklisted keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encrypt the beacon localstorage
2 participants