feat: WalletConnect integration, part 8, verify #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dianasavvatina
force-pushed
the
wc_verify
branch
from
b7ee948 to
0b75581
Compare
dianasavvatina
force-pushed
the
wc_verify
branch
from
0b75581 to
a4fff5c
Compare
dianasavvatina
force-pushed
the
wc_verify
branch
from
a4fff5c to
aaecb51
Compare
dianasavvatina
force-pushed
the
wc_verify
branch
from
aaecb51 to
bf6083f
Compare
OKendigelyan
reviewed
Jan 2, 2025
| </ModalHeader> | ||
| {opts.requestId.sdkType === "walletconnect" ? ( | ||
| <VerifyInfobox | ||
| isScam={opts.isScam ?? false} |
| </SignPageHeader> | ||
| {headerProps.requestId.sdkType === "walletconnect" ? ( | ||
| <VerifyInfobox | ||
| isScam={headerProps.isScam ?? false} |
There was a problem hiding this comment.
headerProps.isScam is enough
| @@ -46,6 +46,10 @@ export const SessionProposalModal = ({ | |||
| const { onClose } = useDynamicModalContext(); | |||
| const { isLoading, handleAsyncAction } = useAsyncActionHandler(); | |||
|
|
|||
| const verifyContext: Verify.Context = proposal.verifyContext; | |||
| const isScam = verifyContext.verified.isScam ?? false; | |||
There was a problem hiding this comment.
verifyContext.verified.isScam is enough
| }) => ( | ||
| <Box textAlign="left" data-testid="verifyinfobox"> | ||
| <VStack margin="auto" marginTop="16px" marginBottom="16px" spacing="16px"> | ||
| {isScam ? ( |
There was a problem hiding this comment.
you can make a builder function to get proper jsx to render
const getVerificationAlert = () => {
const statusOptions = {
SCAM: {
color: "red.500",
icon: AlertTriangleIcon,
text: "This domain is suspected to be a SCAM. Potential threat detected."
},
UNKNOWN: {
color: "yellow.500",
icon: AlertCircleIcon,
text: "This domain is unknown. Cannot verify it."
},
INVALID: {
color: "yellow.500",
icon: AlertTriangleIcon,
text: "This domain is invalid."
},
VALID: {
color: "green.500",
icon: VerifiedIcon,
text: "This domain is verified."
}
};
return (<HStack
margin="auto"
padding="8px"
border="1px solid"
borderColor={statusOptions[validationStatus].color}
borderRadius="md"
>
<Icon as={statusOptions[validationStatus].icon} verticalAlign="bottom" />
<Card marginLeft="8px">{statusOptions[validationStatus].text}</Card>
</HStack>)
};
| }) => ( | ||
| <Box textAlign="left" data-testid="verifyinfobox"> | ||
| <VStack margin="auto" marginTop="16px" marginBottom="16px" spacing="16px"> | ||
| {isScam ? ( |
There was a problem hiding this comment.
Suggested change
| {isScam ? ( | |
| getVerificationAlert() |
OKendigelyan
force-pushed
the
wc_verify
branch
from
bf6083f to
0595f7f
Compare
dianasavvatina
force-pushed
the
wc_verify
branch
from
0595f7f to
6858a9c
Compare
dianasavvatina
force-pushed
the
wc_verify
branch
from
6858a9c to
6127b2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added domain verification for WalletConnect and Beacon.
Beacon has no verification and writes "UNKNOWN" for all domains.
Types of changes
Steps to reproduce
Screenshots
Add the screenshots of how the app used to look like and how it looks now
Checklist